-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd: Remove invalid snap ID test skip #1021
Open
anoopcs9
wants to merge
1
commit into
ceph:master
Choose a base branch
from
anoopcs9:rm-getsnaptimestamp-test-skip
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One example failure, FWIW:
|
anoopcs9
force-pushed
the
rm-getsnaptimestamp-test-skip
branch
2 times, most recently
from
August 19, 2024 15:46
19e53f4
to
7c24797
Compare
Quincy backport is pending a release and thus CI job failed with SIGABRT for test-suite (quincy). I can see that ceph/ceph#55473 is already merged for v17.2.8 milestone. |
anoopcs9
added
the
no-API
This PR does not include any changes to the public API of a go-ceph package
label
Aug 20, 2024
anoopcs9
force-pushed
the
rm-getsnaptimestamp-test-skip
branch
2 times, most recently
from
September 4, 2024 05:40
a7ec27a
to
d21b1c3
Compare
phlogistonjohn
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Mergifyio rebase |
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
rm-getsnaptimestamp-test-skip
branch
from
September 25, 2024 14:23
d21b1c3
to
cb576b8
Compare
@Mergifyio rebase |
✅ Branch has been successfully rebased |
phlogistonjohn
force-pushed
the
rm-getsnaptimestamp-test-skip
branch
from
October 10, 2024 17:48
cb576b8
to
905902d
Compare
@Mergifyio rebase |
Fix for https://tracker.ceph.com/issues/47287 is now available with quincy and above releases. Therefore do not skip GetSnapTimestamp API test for an invalid snap ID. Signed-off-by: Anoop C S <[email protected]>
phlogistonjohn
force-pushed
the
rm-getsnaptimestamp-test-skip
branch
from
October 28, 2024 14:03
905902d
to
2a1ca2d
Compare
✅ Branch has been successfully rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://tracker.ceph.com/issues/47287 is now available with quincy and above releases. Therefore do not skip
GetSnapTimestamp
API test for an invalid snap ID.fixes #440
depends on ceph v17.2.8 GA.