Skip to content

Commit b119edd

Browse files
committed
lint: Fixed bug in line / column count of printed syntax errors
Signed-off-by: Ole Herman Schumacher Elgesem <ole.elgesem@northern.tech>
1 parent c65777f commit b119edd

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

src/cfengine_cli/lint.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,15 +140,18 @@ def _single_node_checks(filename, lines, node):
140140

141141

142142
def _walk(filename, lines, node) -> int:
143-
line = node.range.start_point[0] + 1
144-
column = node.range.start_point[1] + 1
145143
error_nodes = _find_node_type(filename, lines, node, "ERROR")
146-
for node in error_nodes:
147-
_highlight_range(node, lines)
148-
print(f"Error: Syntax error at {filename}:{line}:{column}")
149144
if error_nodes:
145+
for node in error_nodes:
146+
line = node.range.start_point[0] + 1
147+
column = node.range.start_point[1] + 1
148+
_highlight_range(node, lines)
149+
print(f"Error: Syntax error at {filename}:{line}:{column}")
150150
return len(error_nodes)
151151

152+
line = node.range.start_point[0] + 1
153+
column = node.range.start_point[1] + 1
154+
152155
errors = 0
153156
for node in _find_nodes(filename, lines, node):
154157
errors += _single_node_checks(filename, lines, node)

0 commit comments

Comments
 (0)