Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Upgrade elliptic and jspdf #2419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

billhimmelsbach
Copy link

@billhimmelsbach billhimmelsbach commented Mar 4, 2025

Based on dependabot vulnerabilities, we'll need to update two libraries: elliptic and jspdf. These are fairly minor updates, so we'll tackle them together.

This will resolve the following PRs:
#2318
#2317
#2413
and several dependabot alerts.

🚀 It's currently up on dev: 3.2.2d 🚀

Changes

  • updates elliptic from 6.5.7 to 6.6.1
  • updates jspdf from 2.5.1 to 2.5.2
  • don't allow minor version updates to jspdf

Testing

  • Search to see if updates to the deps have been tried before, but were blocking changes for some reason in issues, PRs, etc
  • Update package.json, run yarn to update the package.lock
  • Run e2e tests locally
  • Examine where these packages are used and ensure that these updates don't break anything not caught by e2e tests
  • If everything looks good, proceed. Otherwise, revise code and chat with @ojbravo
  • Deploy changes to Dev via CLI, run e2e tests again and test everything
  • Get me admin access to this repo so I can make PRs, label and assign issues, etc.
  • Create a PR and merge in the security updates
  • Create a github release
  • Deploy mLAR changes to Prod via CLI (based on how I understand things currently are working with the caching workaround, these changes won't be visible until a manual deploy is done) - use the same image that's on dev
  • Test things out with the team, confirm e2e tests pass (wait till they run automatically or trigger manually)
  • 🥳

Closes #2418

@billhimmelsbach billhimmelsbach requested a review from ojbravo March 4, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] Update elliptic and jspdf
1 participant