Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser Accepts Blanks or 0s as Blank Values #4124

Open
kgudel opened this issue May 25, 2021 · 3 comments · May be fixed by #4354
Open

Parser Accepts Blanks or 0s as Blank Values #4124

kgudel opened this issue May 25, 2021 · 3 comments · May be fixed by #4354
Assignees
@PatrickGoRaft @lchen-2101
Labels
2022 Improvements

Comments

@kgudel
Copy link
Contributor

kgudel commented May 25, 2021

In fields that are either blank or integers, such as AUS System, the parser first converts the the blank value into a 0 and then maps the integer value 0 to the blank enumerate object. The conversation happens in this method. The mapping into the enumerated object can be seen in AUS System. As such, the parser will accept and convert either a blank or a 0 as the blank object.
@lchen-2101 lchen-2101 self-assigned this Jan 7, 2022
@lchen-2101
Copy link
Contributor

lchen-2101 commented Jan 10, 2022 •
edited
Loading

List of enums this applies to:

ActionTakenTypeEnum
ApplicationSubmissionEnum
AutomatedUnderwritingResultEnum
AutomatedUnderwritingSystemEnum
BalloonPaymentEnum
BusinessOrCommercialBusinessEnum
ConstructionMethodEnum
CreditScoreEnum
DenialReasonEnum
EthnicityEnum
EthnicityObservedEnum
HOEPAStatusEnum
InterestOnlyPaymentsEnum
LarNumericExemptCodeEnum
LienStatusEnum
LineOfCreditEnum
LoanPurposeEnum
LoanTypeEnum
ManufacturedHomeLandPropertyInterestEnum
ManufacturedHomeSecuredPropertyEnum
MortgageTypeEnum
NegativeAmortizationEnum
OccupancyEnum
OtherNonAmortizingFeaturesEnum
PayableToInstitutionEnum
PreapprovalEnum
PurchaserEnum
RaceEnum
RaceObservedEnum
SexEnum
SexObservedEnum

which ones should accept blank as is, and which should convert blank to 0 as is the current logic, or throw an exception if it's blank

@lchen-2101
Copy link
Contributor

clarifications:
for enums with 0 as valid value, it's supposed to be blank, so there are enums that would accept blanks (ones with case 0), and the ones that don't; the ones that don't functions properly. ones that accepts blanks are the issue, where blank would be appropriate, but 0 wouldn't be; so we are accepting 0 values when the system should throw exception.

@lchen-2101
Copy link
Contributor

problem scope is only limited to enums relating to AUS, Denial Reason, Race, and Ethnicity

@lchen-2101 lchen-2101 linked a pull request Jan 11, 2022 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PatrickGoRaft PatrickGoRaft

@lchen-2101 lchen-2101

Labels
2022 Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] adjusted lar enums to have blank value without using 0 lchen-2101/hmda-platform
4 participants
@kgudel @PatrickGoRaft @JamalStarling1 @lchen-2101