Skip to content
This repository was archived by the owner on May 12, 2023. It is now read-only.

Github SSO fails by not retrieving email address #7

Open
sbauza opened this issue Sep 23, 2016 · 4 comments
Open

Github SSO fails by not retrieving email address #7

sbauza opened this issue Sep 23, 2016 · 4 comments

Comments

@sbauza
Copy link

sbauza commented Sep 23, 2016

When testing to access https://snowcamp.cfp.io using the GitHub authentication, I'm unable to log in and CFP.io returns me the following error :
" We can't retrieve your e-mail with the selected provider (check if you don't set it private). You can use another provider if you want. "

I verified my GitHub account and my email address is not set private.
Using LinkedIn SSO works seamlessly, so I suspect the GitHub scope being looked up as incorrect.

@ndeloof
Copy link
Collaborator

ndeloof commented Sep 23, 2016

github API does not return your email as part of the authorization API call. Please check you have one set on your github profile

@sbauza
Copy link
Author

sbauza commented Sep 23, 2016

I just checked the applications I granted and most of them scope my email address as well, without noticying any problem with those. I just verified that I was able to access my ngrok account thru their SSO and they exactly ask for the same permissions than CFP.io.

[sbauza@sbauza nova]$ curl -u "sbauza" -H "Accept: application/vnd.github.damage-preview" https://api.github.com/applications/grants
Enter host password for user 'sbauza':
[
{
"id": 22545799,
"url": "https://api.github.com/applications/grants/22545799",
"app": {
"name": "ngrok.com",
"url": "https://ngrok.com",
"client_id": "XXXXX"
},
"created_at": "2016-07-04T08:01:00Z",
"updated_at": "2016-07-04T08:01:01Z",
"scopes": [
"user:email"
]
},
{
"id": 7287874,
"url": "https://api.github.com/applications/grants/7287874",
"app": {
"name": "Gitter Public Repo Access",
"url": "https://gitter.im/?redirect=no",
"client_id": "XXXX"
},
"created_at": "2015-11-20T07:06:26Z",
"updated_at": "2016-09-16T21:16:31Z",
"scopes": [
"read:org",
"user:email"
]
},
{
"id": 25156191,
"url": "https://api.github.com/applications/grants/25156191",
"app": {
"name": "review.rdoproject.org",
"url": "https://review.rdoproject.org/",
"client_id": "XXXX"
},
"created_at": "2016-09-01T12:53:15Z",
"updated_at": "2016-09-01T12:53:16Z",
"scopes": [
"read:org",
"read:public_key",
"user:email"
]
},
{
"id": 25374358,
"url": "https://api.github.com/applications/grants/25374358",
"app": {
"name": "cfp.io",
"url": "http://www.cfp.io",
"client_id": "XXXXXX"
},
"created_at": "2016-09-06T12:54:50Z",
"updated_at": "2016-09-23T09:45:19Z",
"scopes": [
"user:email"
]
}
]

@ndeloof
Copy link
Collaborator

ndeloof commented Sep 23, 2016

You're welcome to contribute a fix if you understand what's wrong here.

@ghost
Copy link

ghost commented Sep 23, 2016

Check your Github profile, your email must be "public" :

VALID:

capture d ecran 2016-09-23 16 25 57

WRONG:

capture d ecran 2016-09-23 16 24 18

Michel.

2016-09-23 12:29 GMT+02:00 Nicolas De loof [email protected]:

You're welcome to contribute a fix if you understand what's wrong here.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATpEW-qKordW48Gyc8sgKwhSt38BA3Nks5qs6n8gaJpZM4KEyjL
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants