Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback on meaning of the argument #4

Open
coreyfarrell opened this issue May 19, 2020 · 0 comments
Open

Feedback on meaning of the argument #4

coreyfarrell opened this issue May 19, 2020 · 0 comments
Labels
question Further information is requested

Comments

@coreyfarrell
Copy link
Member

Currently the argument is interpreted as a filename - path.dirname is run on it. So if you run getPackageType('/path/to/pkg') it will not see /path/to/pkg/package.json.

Should this be reconsidered before v1.0.0?
@coreyfarrell coreyfarrell added the question Further information is requested label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coreyfarrell