help-check does not see failures

[smoser]

help-check seems to try to hard to let things succeed.
If a program exits 1 (which is very common) then help-check will call it good.

$ apk info -v | grep help-check
help-check-0.0.37-r1

$ cat /usr/bin/bad-dude 
#!/bin/sh
echo FAIL FATAL BAD
exit 1

$ ls -l /usr/bin/bad-dude 
-rwxr-xr-x 1 root root 37 Jan 27 15:23 /usr/bin/bad-dude

$ bad-dude  ; echo $?
FAIL FATAL BAD
1

$ help-check --bins=/usr/bin/bad-dude 
INFO[help-check]: Starting help checks for: /usr/bin/bad-dude
INFO[help-check]: Help flag: auto
PASS[help-check]: '/usr/bin/bad-dude' help check
INFO[help-check]: tested 1 binaries. 1 passes. 0 fails.

[smoser]

fyi, @murraybd

[murraybd]

@AbduAzim424 Was this intentional at all?

[smoser]

@murraybd I think the point was to not force things that exited non-zero on -h / --help fail this test.

[smoser]

#294 is related, in ver-check.