Merge pull request #7118 from christianbeeznest/ofaj-23108

NicoDucou · web-flow · commit 5ea3d096d548 · 2025-11-28T09:07:01.000+01:00
Exercise: Show only latest audio feedback player - refs BT#23108
diff --git a/public/main/inc/lib/exercise.lib.php b/public/main/inc/lib/exercise.lib.php
@@ -5606,12 +5606,12 @@ public static function getOralFeedbackAudio(int $attemptId, int $questionId): st
             return '';
         }
 
-        $html = '';
-
         $assetRepo = Container::getAssetRepository();
+        $html = '';
 
+        // Keep only the latest audio feedback to avoid duplicated players
         foreach ($qAttempt->getAttemptFeedbacks() as $attemptFeedback) {
-            $html .= Display::tag(
+            $html = Display::tag(
                 'audio',
                 '',
                 [

Original file line number	Diff line number	Diff line change
`@@ -5606,12 +5606,12 @@ public static function getOralFeedbackAudio(int $attemptId, int $questionId): st`
`5606`	`5606`	`return '';`
`5607`	`5607`	`}`
`5608`	`5608`
`5609`		`- $html = '';`
`5610`		`-`
`5611`	`5609`	`$assetRepo = Container::getAssetRepository();`
	`5610`	`+ $html = '';`
`5612`	`5611`
	`5612`	`+ // Keep only the latest audio feedback to avoid duplicated players`
`5613`	`5613`	`foreach ($qAttempt->getAttemptFeedbacks() as $attemptFeedback) {`
`5614`		`- $html .= Display::tag(`
	`5614`	`+ $html = Display::tag(`
`5615`	`5615`	`'audio',`
`5616`	`5616`	`'',`
`5617`	`5617`	`[`