-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selector and Counter Bundlize as one #144
Comments
Hey @c0ncentus, Thanks for the great suggestion! And thank you for using the package for a long time. To clarify, would you like a component with a counter and selector so that the state can be shared between the two? Currently, there has to be a parent component that manages the state and shares it between the two? I like this idea, but it might take longer to implement. |
"To clarify, would you like a component with a counter and selector so that the state can be shared between the two?" Yes completely. "Currently, there has to be a parent component that manages the state and shares it between the two?" Yes currently, it is ! thats why my suggestion. an alternative use <Bundle>
<Counter/>
<Selector/>
</Bundle> But not sure if it's work. But if only 1 configuration is available (Counter and Selector) will be fine with events. I'm ok with the time. |
Thanks for the quick response! I like the I'll come up with an API and ask for your feedback in about a week's time. |
Hey @c0ncentus, I like the simple API example you provided. I haven't had time yet to work on it so I can't guarantee when it will be released. You are welcome to try making a PR that adds this feature. |
Is your feature request related to a problem? Please describe.
Add one type of Component, One for rule the all !
Exemple <Bundlize counter={<GithubCounter_ />} Selectors={<SlackSelector_ />} events={(e)=>{}} />
Describe the solution you'd like
it would be appreciable to have this instantly without managing events/state all the times
it would make sens in <Bundlize counter={<GithubCounter_ />} Selectors={ /> events links are bound ...
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Component are seperate UI and visual concept, but would make sens to make as one for user commun use !
The text was updated successfully, but these errors were encountered: