fix: return tty name

Author: aymanbagabas

pty_other.go

@@ -11,6 +11,14 @@ import (
 
 type impl struct{}
 
+func (i *impl) IsZero() bool {
+	return true
+}
+
+func (i *impl) Name() string {
+	return ""
+}
+
 func (i *impl) Read(p []byte) (n int, err error) {
 	return 0, ErrUnsupported
 }

pty_unix.go

@@ -21,9 +21,15 @@ type impl struct {
 
 	// Slave is the slave PTY file descriptor.
 	Slave *os.File
+}
+
+func (i *impl) IsZero() bool {
+	return i.Master == nil && i.Slave == nil
+}
 
-	// Name is the name of the slave PTY.
-	Name string
+// Name returns the name of the slave PTY.
+func (i *impl) Name() string {
+	return i.Slave.Name()
 }
 
 // Read implements ptyInterface.
@@ -60,10 +66,13 @@ func (i *impl) Resize(w int, h int) (rErr error) {
 }
 
 func (i *impl) start(c *exec.Cmd) error {
-	c.Stdin, c.Stdout, c.Stderr := i.Slave, i.Slave, i.Slave
+	c.Stdin, c.Stdout, c.Stderr = i.Slave, i.Slave, i.Slave
 	if c.SysProcAttr == nil {
 		c.SysProcAttr = &syscall.SysProcAttr{}
 	}
+	c.SysProcAttr.Setctty = true
+	c.SysProcAttr.Setsid = true
+	return c.Start()
 }
 
 func newPty(_ Context, _ string, win Window, modes ssh.TerminalModes) (_ impl, rErr error) {
@@ -83,7 +92,7 @@ func newPty(_ Context, _ string, win Window, modes ssh.TerminalModes) (_ impl, r
 		return impl{}, err
 	}
 
-	return impl{Master: ptm, Slave: pts, Name: pts.Name()}, rErr
+	return impl{Master: ptm, Slave: pts}, rErr
 }
 
 func applyTerminalModesToFd(fd uintptr, width int, height int, modes ssh.TerminalModes) error {

pty_windows.go

@@ -19,6 +19,14 @@ type impl struct {
 	*conpty.ConPty
 }
 
+func (i *impl) IsZero() bool {
+	return i.ConPty == nil
+}
+
+func (i *impl) Name() string {
+	return "windows-pty"
+}
+
 func (i *impl) Read(p []byte) (n int, err error) {
 	return i.ConPty.Read(p)
 }

session.go

@@ -364,7 +364,7 @@ func (sess *session) handleRequests(reqs <-chan *gossh.Request) {
 
 				defer closer() // nolint: errcheck
 
-				if !sess.EmulatedPty() {
+				if !sess.EmulatedPty() && !sess.pty.IsZero() {
 					go func() {
 						for win := range sess.winch {
 							if err := resizePty(sess, win); err != nil {