Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Router E2E Tests #1089

Closed
boodland opened this issue Aug 19, 2024 · 6 comments
Closed

Page Router E2E Tests #1089

boodland opened this issue Aug 19, 2024 · 6 comments
Assignees
Labels
complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days feature/enhancement New feature or request
Milestone

Comments

@boodland
Copy link
Contributor

boodland commented Aug 19, 2024

Sub issue of #702

As discussed in #1064
E2E tests of the current pages should be created in order to migrate from pages router to app router more confident.

The pages to cover with E2E tests are:

If a test already exists for the page, add missing tests if required.

@boodland
Copy link
Contributor Author

boodland commented Aug 19, 2024

@kyleecodes, @eleanorreem or @annarhughes could you assign it to me please?

Copy link
Contributor

Thank you @boodland you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨


Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn here and explore our projects. 🌸

@kyleecodes kyleecodes added feature/enhancement New feature or request complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days labels Aug 26, 2024
@kyleecodes kyleecodes added this to the 02. Roadmaps milestone Aug 26, 2024
This was referenced Aug 27, 2024
@boodland
Copy link
Contributor Author

@eleanorreem, @annarhughes
Could you tell me how I could access to /partnership/badoo or /partnership/bumble or /partnership/fruitz?
I have tried either without a login user or any available ones (super admin, public and partner admin) and I am always getting the same page:

image

Thanks!

@boodland
Copy link
Contributor Author

boodland commented Sep 2, 2024

@eleanorreem, @annarhughes
Could you tell me how I could access to properly call /api/preview, I have seen it is expecting an slug parameter as well as a secret one that should be NEXT_PUBLIC_STORYBLOK_TOKEN value. I have tried using chat as the slug value but I am getting the following page:

image

Thanks!

This was referenced Sep 2, 2024
@eleanorreem
Copy link
Contributor

@boodland sorry i missed all these questions!
don't worry about having a test for /partnership/badoo or /partnership/bumble or /partnership/fruitz and also /api/preview.

@eleanorreem
Copy link
Contributor

Thanks I'll mark this as complete! Everything you have done so far should safeguard enough. ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: advanced Time needed to do this ticket will be large e.g. 2-3+ days feature/enhancement New feature or request
Development

No branches or pull requests

3 participants