Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: slice types should be omitted when empty, else they are 'null' in resulting JSON #14

Open
devilleweppenaar opened this issue Nov 26, 2020 · 0 comments
Open

bug: slice types should be omitted when empty, else they are 'null' in resulting JSON #14

devilleweppenaar opened this issue Nov 26, 2020 · 0 comments
Assignees
@ianaya89
Labels
type: bug Something isn't working

Comments

@devilleweppenaar
Copy link

devilleweppenaar commented Nov 26, 2020 •
edited
Loading

The resulting JSON for the checkly.Check struct contains null values for slice values that are not provided. Examples of this are:

  • Check.Locations
  • Check.EnvironmentVariables
  • Check.Tags
  • Request.Headers
  • Request.QueryParameters
  • Request.Assertions

We should add the ,omitempty annotation so that these values are not passed as null in the JSON.
@devilleweppenaar devilleweppenaar changed the title Array types should be omitted when empty, else they are 'null' in resulting JSON Slice types should be omitted when empty, else they are 'null' in resulting JSON Nov 26, 2020
devilleweppenaar added a commit to devilleweppenaar/checkly-go-sdk that referenced this issue Nov 26, 2020
@devilleweppenaar
add omitempty to optional slices; fixes checkly#14
d4f88d9
@devilleweppenaar devilleweppenaar mentioned this issue Nov 26, 2020
Merged
@ianaya89 ianaya89 self-assigned this Jun 16, 2021
ianaya89 pushed a commit that referenced this issue Jul 6, 2021
@devilleweppenaar
feat: JSON fixes for optional fields (#15)
f27cf2c 
* make AlertSettings pointer types; fixes #13

* add omitempty to optional slices; fixes #14

Co-authored-by: Nacho Anaya <[email protected]>
@ianaya89 ianaya89 added the type: bug Something isn't working label Jun 27, 2022
@ianaya89 ianaya89 changed the title Slice types should be omitted when empty, else they are 'null' in resulting JSON bug: slice types should be omitted when empty, else they are 'null' in resulting JSON Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianaya89 ianaya89

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianaya89 @devilleweppenaar