Bug in RegExp

[robodal]

php-qrcode/src/Data/AlphaNum.php

Line 30 in 9964cf8

private const CHAR_MAP = '0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ $%*+-./:';

https://onlinephp.io/c/215012

(bool)preg_match('#^[+-.]+$#', ',') = true
BUT
(bool)preg_match('#^[+.-]+$#', ',') = false

[robodal]

php-qrcode/src/Data/AlphaNum.php

Line 39 in 9964cf8

return (bool)preg_match('#^['.self::CHAR_MAP.']+$#', $string);

[codemasher]

Oh, good catch. Some of those characters should be escaped, I guess I'll just regex that bit the regular way then.

[codemasher]

Ok, so I added a test case similar to the example you posted and it runs without issues with the charmap string linked above. However, the issue occurs if the minus within the charmap is moved to the end after the colon, in which case it is interpreted as meta-character.
Either way i think I'm gonna change the regex to make it foolproof.

[codemasher]

This is it. The minus it kind of problematic within the regex, it has to be in a specific position to not cause problems apparently, but also it can't be escaped as this would break the regex too.

preg_match('/^[A-Z\d %$*+-.:\/]+$/', $string);