Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the chocolateysetup.psm1 module #3255

Open
2 tasks done
vexx32 opened this issue Jul 6, 2023 · 0 comments · May be fixed by #3256
Open
2 tasks done

Rewrite the chocolateysetup.psm1 module #3255

vexx32 opened this issue Jul 6, 2023 · 0 comments · May be fixed by #3256
Assignees
@vexx32
Labels
3 - Review Improvement

Comments

@vexx32
Copy link
Member

vexx32 commented Jul 6, 2023

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

The chocolateysetup.psm1 module that the chocolatey nupkg loads to install Chocolatey CLI itself was first written a very long time ago, and it uses code style that is not maintainable. As a result, we tend to avoid touching it as much as possible.

Describe The Solution. Why is it needed?

Rewrite the module using more modern PowerShell patterns and make it much easier to maintain and make any necessary changes to going forward.

Additional Context

No response

Related Issues

No response
@vexx32 vexx32 self-assigned this Jul 6, 2023
vexx32 added a commit to vexx32/choco that referenced this issue Jul 6, 2023
@vexx32
(chocolatey#3255) Rewrite chocolateysetup.psm1
6ff4e21 
This script has barely been touched in the last decade, in part because
it's difficult to follow. Gave it a much needed revision to remove
unnecessary clutter, make its code patterns more consistent, and be much
more sensible in how it declares and calls commands, so that we can be
much more confident that things are working how we expect them to.

This should help make it much easier to make changes to going forward,
should we ever need to.
vexx32 added a commit to vexx32/choco that referenced this issue Jul 6, 2023
@vexx32
(chocolatey#3255) Rewrite chocolateysetup.psm1
cc4cc5c 
This script has barely been touched in the last decade, in part because
it's difficult to follow. Gave it a much needed revision to remove
unnecessary clutter, make its code patterns more consistent, and be much
more sensible in how it declares and calls commands, so that we can be
much more confident that things are working how we expect them to.

This should help make it much easier to make changes to going forward,
should we ever need to.
@vexx32 vexx32 linked a pull request Jul 6, 2023 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vexx32 vexx32

Labels
3 - Review Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#3255) Rewrite chocolateysetup.psm1 vexx32/choco
1 participant
@vexx32