Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging releases #24

Open
oscherler opened this issue Jul 4, 2014 · 6 comments
Open

Tagging releases #24

oscherler opened this issue Jul 4, 2014 · 6 comments

Comments

@oscherler
Copy link

Ever heard of tagging releases? It’s really handy, it allows you to mark a given commit as stable, which allows people to use the software without requiring dev-master and suffer from the weathercock behaviour of some contributors, like this:

f1a5596 Fixing zrangebyscore. (which is in fact breaking it)
37ea2e2 Removing unneeded fix in last commit.
110e213 Revert "Removing unneeded fix in last commit." (which was a really stupid thing to do)

Today I’m hit with chrisboulton/php-resque#50 and I can’t fix it because I should switch php-resque to dev-master, which requires me to use php-resque-scheduler in dev-master, which is broken because of the above example.

@danhunsaker
Copy link
Contributor

Guess what? Releases have been tagged. Ever heard of not being a jerk to project maintainers?

As to the example you cited above, it's actually more complicated than that. Differences between Credis and the php-redis extension mean that users without the extension need the unfixed code, and users with it need the fix. So now we have to either do Credis's job for it and detect whether the extension is active, then choose the appropriate call, or get the Credis devs to update their code to properly handle the call. With all three projects going a bit stale due to time limitations for those with commit rights, this will be tricky, but we're working on it.

If you need this right this second, create a fork and handle it there. That's what forks are for. But try to be a little less antagonsitic toward the maintainers of a project you intend to use, and get support for.

@oscherler
Copy link
Author

Guess what? Releases have been tagged.

Oh yes, I see that php-resque was tagged 1.2 on Oct 13, 2012. Wow.

Ever heard of not being a jerk to project maintainers?

Yes, I do that.

I turn it off after a threshold number of facepalms is reached, though, for survival.

If you need this right this second, create a fork and handle it there. That's what forks are for. But try to be a little less antagonsitic toward the maintainers of a project you intend to use, and get support for.

There’s a misunderstanding: I don’t intend to use this anymore, let alone get support for it.

@danhunsaker
Copy link
Contributor

Then why spend the time commenting on it?

@oscherler
Copy link
Author

So that people considering using this are warned that it’s not useable, and don’t lose the same amount of time I did.

@justechn
Copy link

What is the status on this? I am trying to install this for the first time and I am getting a notice and warning.

Warning: strlen() expects parameter 1 to be string, array given in /var/www/SalesIndicator/ext/colinmollenhour/credis/Client.php on line 1110

Notice: Array to string conversion in /var/www/SalesIndicator/ext/colinmollenhour/credis/Client.php on line 1110

@danhunsaker
Copy link
Contributor

Install the PHP-Redis extension. That will fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants