Skip to content

Commit ed4c9a6

Browse files
committed
Fix bower config, some grunt/jsdoc etc tweaks
1 parent 35fe59c commit ed4c9a6

File tree

6 files changed

+15
-19
lines changed

6 files changed

+15
-19
lines changed

Gruntfile.js

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ module.exports = function (grunt) {
3131
build: {
3232
src: [
3333
'src/common.js',
34+
'src/resolve.js',
3435
'src/templateFactory.js',
3536
'src/urlMatcherFactory.js',
3637
'src/urlRouter.js',
@@ -65,24 +66,21 @@ module.exports = function (grunt) {
6566
},
6667
watch: {
6768
files: ['src/*.js', 'test/**/*.js'],
68-
tasks: ['build', 'karma:debug:run']
69+
tasks: ['build', 'karma:background:run']
6970
},
7071
connect: {
7172
server: {}
7273
},
7374
karma: {
75+
options: {
76+
configFile: 'config/karma.js'
77+
},
7478
unit: {
75-
configFile: 'test/test-config.js',
76-
runnerPort: 9999,
77-
singleRun: true,
78-
browsers: ['PhantomJS']
79+
singleRun: true
7980
},
80-
81-
debug: {
82-
configFile: 'test/test-config.js',
83-
runnerPort: 9999,
81+
background: {
8482
background: true,
85-
browsers: ['Chrome']
83+
browsers: [ grunt.option('browser') || 'PhantomJS' ]
8684
}
8785
}
8886
});
@@ -91,11 +89,11 @@ module.exports = function (grunt) {
9189
grunt.registerTask('build', 'Perform a normal build', ['concat', 'uglify']);
9290
grunt.registerTask('dist', 'Perform a clean build and generate documentation', ['clean', 'build', 'jsdoc']);
9391
grunt.registerTask('release', 'Tag and perform a release', ['prepare-release', 'dist', 'perform-release']);
94-
grunt.registerTask('dev', 'Run dev server and watch for changes', ['build', 'connect', 'karma:debug', 'watch']);
92+
grunt.registerTask('dev', 'Run dev server and watch for changes', ['build', 'connect', 'karma:background', 'watch']);
9593

9694
grunt.registerTask('jsdoc', 'Generate documentation', function () {
9795
promising(this,
98-
system('node_modules/jsdoc/jsdoc -c jsdoc-conf.json -d \'' + grunt.config('builddir') + '\'/doc src')
96+
system('node_modules/jsdoc/jsdoc -c config/jsdoc.js -d \'' + grunt.config('builddir') + '\'/doc src')
9997
);
10098
});
10199

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "ui-router",
2+
"name": "angular-ui-router",
33
"version": "0.0.2",
44
"main": "./release/angular-ui-router.min.js",
55
"dependencies": {
File renamed without changes.

test/test-config.js renamed to config/karma.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ files = [
1212
'test/testUtils.js',
1313

1414
'src/common.js',
15+
'src/resolve.js',
1516
'src/templateFactory.js',
1617
'src/urlMatcherFactory.js',
1718
'src/urlRouter.js',
@@ -37,9 +38,6 @@ reporter = 'dots';
3738
// web server port
3839
port = 8080;
3940

40-
// cli runner port
41-
runnerPort = 9100;
42-
4341
// enable / disable colors in the output (reporters and logs)
4442
colors = true;
4543

@@ -60,4 +58,5 @@ autoWatchInterval = 0;
6058
// - Opera
6159
// - Safari
6260
// - PhantomJS
63-
browsers = [];
61+
browsers = [ 'PhantomJS' ];
62+

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"grunt-contrib-connect": "~0.2.0",
3737
"grunt-contrib-clean": "~0.4.0",
3838
"grunt-karma": "~0.4.3",
39-
"jsdoc": "git://github.com/jsdoc3/jsdoc.git#v3.1.0",
39+
"jsdoc": "git://github.com/jsdoc3/jsdoc.git#v3.1.1",
4040
"shelljs": "~0.1.4",
4141
"faithful-exec": "~0.1.0"
4242
}

test/compat/routeSpec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ describe('$route', function() {
4343
$rootScope.$digest();
4444
$httpBackend.flush();
4545
expect(log).toEqual('before();after();');
46-
debugger;
4746
expect($route.current.params).toEqual({book:'Moby', chapter:'Intro', p:'123'});
4847

4948
log = '';

0 commit comments

Comments
 (0)