From ae891edb24b0975b3ba3b6e71cf80c77d786e8d1 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 3 Nov 2022 13:15:47 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- .../pygments/lexers/_php_builtins.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/mkdoc_api/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py b/mkdoc_api/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py index ad54492f..359792d3 100644 --- a/mkdoc_api/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py +++ b/mkdoc_api/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py @@ -4726,7 +4726,26 @@ def get_php_functions(): def get_php_references(): download = urlretrieve(PHP_MANUAL_URL) with tarfile.open(download[0]) as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar) yield from glob.glob("%s%s" % (PHP_MANUAL_DIR, PHP_REFERENCE_GLOB)) os.remove(download[0])