phpstan level 9

opencode (opus 4.5)

Author: dominikzogg

composer.json

@@ -52,7 +52,7 @@
         "test:infection": "vendor/bin/infection --threads=$(nproc) --min-msi=83 --verbose --coverage=build/phpunit",
         "test:integration": "vendor/bin/phpunit --testsuite=Integration --cache-directory=build/phpunit",
         "test:lint": "mkdir -p build && find src tests -name '*.php' -print0 | xargs -0 -n1 -P$(nproc) php -l | tee build/phplint.log",
-        "test:static-analysis": "mkdir -p build && bash -c 'vendor/bin/phpstan analyse src --no-progress --level=8 --error-format=junit | tee build/phpstan.junit.xml; if [ ${PIPESTATUS[0]} -ne \"0\" ]; then exit 1; fi'",
+        "test:static-analysis": "mkdir -p build && bash -c 'vendor/bin/phpstan analyse src --no-progress --level=9 --error-format=junit | tee build/phpstan.junit.xml; if [ ${PIPESTATUS[0]} -ne \"0\" ]; then exit 1; fi'",
         "test:unit": "vendor/bin/phpunit --testsuite=Unit --coverage-text --coverage-clover=build/phpunit/clover.xml --coverage-html=build/phpunit/coverage-html --coverage-xml=build/phpunit/coverage-xml --log-junit=build/phpunit/junit.xml --cache-directory=build/phpunit"
     },
     "config": {

src/Exceptions/AbstractMock.php

@@ -69,6 +69,7 @@ private function getObjectData(object $value, array &$splObjectHashes): array|st
             if ($reflectionObject->hasMethod($method)) {
                 $reflectionMethod = $reflectionObject->getMethod($method);
 
+                /** @var array<mixed> */
                 $data = $this->getData($reflectionMethod->invoke($value), $splObjectHashes);
 
                 $data['__CLASS__'] = $value::class;

src/MockClassBuilder.php

@@ -305,15 +305,19 @@ public function enterNode(Node $node): null
                 if ('self' === $node->name) {
                     $reflectionMethod = new \ReflectionMethod($this->mockClassBuilder, 'replaceSelfWithOriginalClassInType');
 
-                    $node->name = $reflectionMethod->invoke($this->mockClassBuilder, $this->reflectionClasses, $this->methodName, 'self');
+                    /** @var non-empty-string */
+                    $name = $reflectionMethod->invoke($this->mockClassBuilder, $this->reflectionClasses, $this->methodName, 'self');
+                    $node->name = $name;
 
                     return null;
                 }
 
                 if ('parent' === $node->name) {
                     $reflectionMethod = new \ReflectionMethod($this->mockClassBuilder, 'replaceSelfWithOriginalClassInType');
 
-                    $node->name = $reflectionMethod->invoke($this->mockClassBuilder, $this->reflectionClasses, $this->methodName, 'parent');
+                    /** @var non-empty-string */
+                    $name = $reflectionMethod->invoke($this->mockClassBuilder, $this->reflectionClasses, $this->methodName, 'parent');
+                    $node->name = $name;
 
                     return null;
                 }
@@ -402,9 +406,12 @@ private function resolveOriginalClassConst(
         if (\is_string($value)) {
             $matches = [];
             if (preg_match('/^'.$this->originalClassConstPattern($reflectionClass).'$/', $value, $matches)) {
+                /** @var null|bool|float|int|string */
+                $constantValue = $reflectionClass->getConstant($matches[1]);
+
                 return $this->resolveOriginalClassConst(
                     $reflectionClass,
-                    $reflectionClass->getConstant($matches[1])
+                    $constantValue
                 );
             }
 

src/MockMethod/WithException.php

@@ -15,7 +15,7 @@ public function __construct(
         string $expectedName,
         array $expectedParameters,
         private readonly \Throwable $exception,
-        mixed $strict = true,
+        bool $strict = true,
     ) {
         $this->withoutReturn = new WithoutReturn(
             $expectedName,

src/MockMethod/WithReturn.php

@@ -15,7 +15,7 @@ public function __construct(
         string $expectedName,
         array $expectedParameters,
         private readonly mixed $return,
-        mixed $strict = true,
+        bool $strict = true,
     ) {
         $this->withoutReturn = new WithoutReturn($expectedName, $expectedParameters, $strict);
     }

src/MockMethod/WithReturnSelf.php

@@ -14,7 +14,7 @@ final class WithReturnSelf implements MockMethodInterface
     public function __construct(
         string $expectedName,
         array $expectedParameters,
-        mixed $strict = true,
+        bool $strict = true,
     ) {
         $this->withoutReturn = new WithoutReturn(
             $expectedName,

src/MockMethod/WithoutReturn.php

@@ -13,7 +13,7 @@ final class WithoutReturn implements MockMethodInterface
     /**
      * @param array<mixed> $expectedParameters
      */
-    public function __construct(private readonly string $expectedName, private readonly array $expectedParameters, private readonly mixed $strict = true) {}
+    public function __construct(private readonly string $expectedName, private readonly array $expectedParameters, private readonly bool $strict = true) {}
 
     /**
      * @param array<mixed> $actualParameters
@@ -118,10 +118,12 @@ private function compareEqual(mixed $actual, mixed $expected): bool
         }
 
         if (\is_array($actual)) {
+            /** @var array<mixed> $expected */
             return $this->compareArrayEqual($actual, $expected);
         }
 
         if (\is_object($actual)) {
+            /** @var object $expected */
             return $this->compareObjectEqual($actual, $expected);
         }