Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Feat/yml support #699

Closed
wants to merge 12 commits into from
Closed

Feat/yml support #699

wants to merge 12 commits into from

Conversation

KarimGl
Copy link
Collaborator

@KarimGl KarimGl commented Mar 22, 2022

Issue Number

fixes #170

Describe the changes you've made

  • On UI, scenarios and global var edition is with YAML and not hjson.
  • migrate old hjson global var files to yaml on server startup.
  • add yaml spel function

Describe if there is any unusual behaviour of your code

NA

Additional context

Test plan

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@boddissattva
Copy link
Member

We have to check that when saving a element as a yaml multiline, this format persist after.

@codecov-commenter
Copy link

Codecov Report

Merging #699 (5ff3069) into master (9b8a76c) will increase coverage by 0.03%.
The diff coverage is 78.47%.

❗ Current head 5ff3069 differs from pull request most recent head 2e8f9f7. Consider uploading reports for the commit 2e8f9f7 to get more accurate results

@@             Coverage Diff              @@
##             master     #699      +/-   ##
============================================
+ Coverage     74.01%   74.05%   +0.03%     
- Complexity     3512     3537      +25     
============================================
  Files           644      648       +4     
  Lines         15179    15275      +96     
  Branches        879      886       +7     
============================================
+ Hits          11235    11312      +77     
- Misses         3496     3511      +15     
- Partials        448      452       +4
Impacted Files Coverage Δ
.../main/java/com/chutneytesting/ServerBootstrap.java 0.00% <0.00%> (ø)
...eytesting/changelog/hjsontoyaml/YAMLGenerator.java 44.00% <44.00%> (ø)
...om/chutneytesting/task/function/YamlFunctions.java 71.42% <71.42%> (ø)
...ting/design/api/globalvar/GlobalVarController.java 75.00% <83.33%> (+6.25%) ⬆️
...fra/storage/globalvar/FileGlobalVarRepository.java 86.45% <85.71%> (+6.45%) ⬆️
...ting/changelog/GlobalVarFileChangelogExecutor.java 91.66% <91.66%> (ø)
...gn/api/scenario/v2_0/mapper/GwtScenarioMapper.java 86.20% <94.11%> (+1.35%) ⬆️
...tneytesting/changelog/hjsontoyaml/YAMLFactory.java 100.00% <100.00%> (ø)
...gn/api/scenario/v2_0/mapper/RawTestCaseMapper.java 93.75% <100.00%> (-0.46%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b8a76c...2e8f9f7. Read the comment docs.

nbrouand
nbrouand suggested changes Apr 25, 2022
View reviewed changes
Copy link
Member

@nbrouand nbrouand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conversion yaml -> json -> yaml doesnt seems to be as smart as expected. (ie presentation is worst in yaml than in json)
Some example :

We cannot have json directly :

document: 
    {
        "json":"value",
        "json2": "value2"
    }
=> 
document:
    json: value
    json2: value2

Long key for by example xml-assert or json-assert are transformed on two lines :
https://stackoverflow.com/questions/36294791/how-do-you-write-multiple-lines-in-a-yaml-key

Does we need to remove completly json store format ?

@boddissattva boddissattva marked this pull request as draft April 26, 2022 08:52
@nbrouand nbrouand closed this Jun 8, 2022
@bessonm bessonm deleted the feat/yml-support branch October 4, 2022 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bessonm bessonm bessonm left review comments

@nbrouand nbrouand nbrouand requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 | Add Yaml support
5 participants
@KarimGl @boddissattva @codecov-commenter @bessonm @nbrouand