Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GLAD to version 2 #2305

Open
totalgee opened this issue Apr 11, 2023 · 1 comment
Open

Update GLAD to version 2 #2305

totalgee opened this issue Apr 11, 2023 · 1 comment
Labels

Comments

@totalgee
Copy link
Contributor

This is just a nice-to-have, mainly to get rid of the annoying warnings that often show up under Windows (due to redefinition of APIENTRY when you need to include windows.h in a file, but Cinder has already indirectly included glad.h). The GLAD v1 explicitly defines APIENTRY in its header). In GLAD 2, they now use a different define within their library (GLAD_API_PTR), so this warning is gone.

The new GLAD (v2) generator is here: https://gen.glad.sh//
However, I suspect it will be a bit more complicated than just swapping in new generated headers and source files, because the GLAD API changed a bit (also it has more options, so I'm not sure which are best for Cinder).

Just adding this issue as a reminder.

@totalgee
Copy link
Contributor Author

Just adding the link here to some of the comments in #2332 (which is not really necessary and I'm going to close now, since #2339 resolved the GLAD v1 compile warnings for now)... The bigger move to GLAD v2 will be left (in this issue) for a later time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants