Skip to content

show secrets.py when appropriate #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jepler opened this issue Jun 17, 2021 · 2 comments
Closed

show secrets.py when appropriate #6

jepler opened this issue Jun 17, 2021 · 2 comments

Comments

@jepler
Copy link
Contributor

jepler commented Jun 17, 2021

[this is not based on user feedback, just something that occurred to me]

I wonder whether the folder screenshots should show the secrets.py file (probably based on certain libraries, like requests, being installed)

.. this sort of speaks to the question of whether this shows what is in the ZIP file or what is in the CIRCUITPY drive...

@FoamyGuy
Copy link
Collaborator

I think I had considered this at one point but didn't come up with a satisfactory way to know if it was required or not. Perhaps a list of "needs_secrets" libraries can be stored somewhere, but there are some libraries that could be optional. Like using the pyportal or magtag libraries but not for network things would not need a secrets.py file in order to work.

The original intent was to show the CIRCUITPY drive as it would look when running the project.

@FoamyGuy
Copy link
Collaborator

This is handled now ultimately with a list of libraries known to require settings.toml which gets added if any of these libraries are in use. https://github.com/circuitpython/CircuitPython_Library_Screenshot_Maker/blob/main/settings_required.py#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants