This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Pretty and sanitizier xml #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2019 18:52
It uses xmllint if it's available, otherwise the content is not modified.
Pull Request Test Coverage Report for Build 120
💛 - Coveralls |
spbnick
reviewed
Jan 25, 2019
| @@ -50,6 +52,28 @@ def print_test_cases(patches, dbdir, pw_cookie=None): | |||
| print(test_case) | |||
|
|
|||
|
|
|||
| def pretty_xml(xml_content): | |||
There was a problem hiding this comment.
I'd prefer this was at least named maybe_pretty_xml(), try_prettify_xml(), or something like that, or, better, that kpet would have an option to turn this off (or on), and the function doing it unconditionally. Otherwise kpet users as well as developers would find it confusing that this sometimes works and sometimes doesn't without apparent reason.
Another way could be requiring xmllint, but we can't do that with just Python packaging, as you know.
|
Hi! This is the friendly CKI test bot. Whenever you mention me in a comment together with the word "test", I will test this PR and post the results! |
|
Superseded by #49 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pretty_xml for check, reformat and re-indent. It uses xmllint if it's available, otherwise the content is not modified. It closes #19