From 457ba9d396b72b011ba8bfbe872469ef832c32d1 Mon Sep 17 00:00:00 2001 From: "Rebecca N. Palmer" Date: Sat, 2 Feb 2019 21:24:15 +0000 Subject: [PATCH] Remove unusable, and unbuildable in GCC 8, GetTypecode This template function has always been non-instantiable as char[4] to char& is an invalid conversion. Older GCC didn't notice as we never try, but in GCC 8 its existence is an error: https://gcc.gnu.org/gcc-8/porting_to.html#hypothetical-instantiation --- src/benchmarks/cusparse-bench/src/mm_reader.cpp | 5 ----- src/library/io/mm-reader.cpp | 5 ----- 2 files changed, 10 deletions(-) diff --git a/src/benchmarks/cusparse-bench/src/mm_reader.cpp b/src/benchmarks/cusparse-bench/src/mm_reader.cpp index 033d55d..e6ac0eb 100644 --- a/src/benchmarks/cusparse-bench/src/mm_reader.cpp +++ b/src/benchmarks/cusparse-bench/src/mm_reader.cpp @@ -103,11 +103,6 @@ class MatrixMarketReader return isSymmetric; } - char &GetTypecode( ) - { - return Typecode; - } - Coordinate *GetUnsymCoordinates( ) { return unsym_coords; diff --git a/src/library/io/mm-reader.cpp b/src/library/io/mm-reader.cpp index 48f378a..c67e196 100644 --- a/src/library/io/mm-reader.cpp +++ b/src/library/io/mm-reader.cpp @@ -118,11 +118,6 @@ class MatrixMarketReader return isSymmetric; } - char &GetTypecode( ) - { - return Typecode; - } - Coordinate *GetUnsymCoordinates( ) { return unsym_coords;