Skip to content

Commit a2405b1

Browse files
author
Clark Wang
committed
fix error in fastify 2.x
1 parent 3a70421 commit a2405b1

File tree

10 files changed

+49
-38
lines changed

10 files changed

+49
-38
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,4 @@ typings/
6161
.next
6262

6363
.idea
64+
dist

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"@angular/platform-browser-dynamic": ">=7.0.0",
3030
"@angular/platform-server": ">=7.0.0",
3131
"@angular/router": ">=7.0.0",
32+
"@types/node": "^11.13.4",
3233
"fastify": ">=2.1.0",
3334
"lerna": "^3.13.0",
3435
"rxjs": "^6.3.3",

packages/fastify-angular/index.js

+1-9
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,7 @@ function fastifyAngular(fastify, opts, next) {
1414
.register(require('./plugins/locale'), {
1515
browser: opts.browser,
1616
i18n : opts.i18n,
17-
})
18-
.after(() => {
19-
fastify.supportedBrowserLocales.forEach((locale) => {
20-
fastify.register(fastifyAngularBundle, {
21-
prefix : locale ? `/${locale}/` : '/',
22-
locale : locale,
23-
browser: join(opts.browser, locale),
24-
});
25-
});
17+
bundle : fastifyAngularBundle,
2618
});
2719

2820
if (opts.universal) {

packages/fastify-angular/plugins/locale.js

+8
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,14 @@ function fastifyAngularLocale(fastify, opts, next) {
2323
},
2424
});
2525

26+
locales.forEach((locale) => {
27+
fastify.register(opts.bundle, {
28+
prefix : locale ? `/${locale}/` : '/',
29+
locale : locale,
30+
browser: join(opts.browser, locale),
31+
});
32+
});
33+
2634
next();
2735
}
2836

packages/test-app/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
"fastify": ">=2.1.0",
5555
"fastify-language-parser": "^2.0.0",
5656
"fastify-static": "^2.4.0",
57+
"fastify-accepts": "^0.5.0",
5758
"rxjs": "~6.3.3",
5859
"zone.js": "~0.8.26"
5960
},

packages/test-app/server.ts

+15-22
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,25 @@
11
import 'zone.js/dist/zone-node';
22
import 'reflect-metadata';
33

4-
import * as fastify from 'fastify';
54
import { enableProdMode } from '@angular/core';
65

76
// Faster server renders w/ Prod mode (dev mode never needed)
87
enableProdMode();
98

10-
const PORT = +process.env.PORT || 4000;
9+
export = function server(fastify, opts, next) {
1110

12-
// Fastify server
13-
const app = fastify();
11+
fastify
12+
.register(require('fastify-accepts'))
13+
.register(require('fastify-language-parser'), {
14+
order : ['header'],
15+
fallbackLng : 'en',
16+
supportedLngs: ['zh', 'en'],
17+
})
18+
.register(require('fastify-angular'), {
19+
dist : __dirname,
20+
i18n : true,
21+
universal: true,
22+
});
1423

15-
app
16-
.register(require('fastify-accepts'))
17-
.register(require('fastify-language-parser'), {
18-
order : ['header'],
19-
fallbackLng : 'en',
20-
supportedLngs: ['zh', 'en'],
21-
})
22-
.register(require('fastify-angular'), {
23-
dist : __dirname,
24-
i18n : true,
25-
universal: true,
26-
})
27-
.listen(PORT, (err, address) => {
28-
if (err) {
29-
throw err;
30-
}
31-
console.log(`Node Fastify server listening on ${address}`);
32-
});
24+
next();
25+
};

packages/test-app/server.tsconfig.json

-3
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@
88
"emitDecoratorMetadata": true,
99
"experimentalDecorators": true,
1010
"target": "es5",
11-
"typeRoots": [
12-
"node_modules/@types"
13-
],
1411
"lib": [
1512
"es2017",
1613
"dom"

packages/test-app/src/polyfills.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@
3838
// import 'classlist.js'; // Run `npm install --save classlist.js`.
3939

4040
/** Evergreen browsers require these. **/
41-
import 'core-js/es6/reflect';
42-
import 'core-js/es7/reflect';
41+
// import 'core-js/es6/reflect';
42+
// import 'core-js/es7/reflect';
4343

4444

4545
/**

packages/test-app/tsconfig.json

+3
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
"emitDecoratorMetadata": true,
1010
"experimentalDecorators": true,
1111
"target": "es5",
12+
"types": [
13+
"node"
14+
],
1215
"typeRoots": [
1316
"node_modules/@types"
1417
],

yarn.lock

+17-2
Original file line numberDiff line numberDiff line change
@@ -1033,7 +1033,7 @@
10331033
semver "5.6.0"
10341034
semver-intersect "1.4.0"
10351035

1036-
"@types/node@*", "@types/node@^11.13.0":
1036+
"@types/node@*", "@types/node@^11.13.0", "@types/node@^11.13.4":
10371037
version "11.13.4"
10381038
resolved "https://registry.yarnpkg.com/@types/node/-/node-11.13.4.tgz#f83ec3c3e05b174b7241fadeb6688267fe5b22ca"
10391039
integrity sha512-+rabAZZ3Yn7tF/XPGHupKIL5EcAbrLxnTr/hgQICxbeuAfWtT0UZSfULE+ndusckBItcv4o6ZeOJplQikVcLvQ==
@@ -1238,7 +1238,7 @@ accept-language-parser@^1.5.0:
12381238
resolved "https://registry.yarnpkg.com/accept-language-parser/-/accept-language-parser-1.5.0.tgz#8877c54040a8dcb59e0a07d9c1fde42298334791"
12391239
integrity sha1-iHfFQECo3LWeCgfZwf3kIpgzR5E=
12401240

1241-
accepts@~1.3.4, accepts@~1.3.5:
1241+
accepts@^1.3.3, accepts@~1.3.4, accepts@~1.3.5:
12421242
version "1.3.5"
12431243
resolved "https://registry.yarnpkg.com/accepts/-/accepts-1.3.5.tgz#eb777df6011723a3b14e8a72c0805c8e86746bd2"
12441244
integrity sha1-63d99gEXI6OxTopywIBcjoZ0a9I=
@@ -3558,6 +3558,14 @@ fastfall@^1.5.0:
35583558
dependencies:
35593559
reusify "^1.0.0"
35603560

3561+
fastify-accepts@^0.5.0:
3562+
version "0.5.0"
3563+
resolved "https://registry.yarnpkg.com/fastify-accepts/-/fastify-accepts-0.5.0.tgz#c17c201278f2bfc51bfb93ffe48efc4fc40fd363"
3564+
integrity sha1-wXwgEnjyv8Ub+5P/5I78T8QP02M=
3565+
dependencies:
3566+
accepts "^1.3.3"
3567+
fastify-plugin "^0.2.1"
3568+
35613569
fastify-autoload@^0.7.0:
35623570
version "0.7.0"
35633571
resolved "https://registry.yarnpkg.com/fastify-autoload/-/fastify-autoload-0.7.0.tgz#d55ad8c00bbf9c197dc9d0f9d3969c2fa69cc653"
@@ -3601,6 +3609,13 @@ fastify-plugin@>=1.2.0, fastify-plugin@^1.4.0, fastify-plugin@^1.5.0:
36013609
dependencies:
36023610
semver "^5.5.0"
36033611

3612+
fastify-plugin@^0.2.1:
3613+
version "0.2.2"
3614+
resolved "https://registry.yarnpkg.com/fastify-plugin/-/fastify-plugin-0.2.2.tgz#e01b67685fd02e87edc98670ce2acfe251a2c715"
3615+
integrity sha512-oRJdjdudgCkQQUARNeh2rkbxFAmj2OhCJSVBNBLUbhS0orF+IMQ4u/bc661N1jh/wDI2J+YKmXmmHSVFQI4e7A==
3616+
dependencies:
3617+
semver "^5.4.1"
3618+
36043619
fastify-static@>=0.14.0, fastify-static@^2.4.0:
36053620
version "2.4.0"
36063621
resolved "https://registry.yarnpkg.com/fastify-static/-/fastify-static-2.4.0.tgz#7d3937897a8feaa66a920a915f72a11e795c3351"

0 commit comments

Comments
 (0)