check null on callback method with

iqbalatma · iqbalatma · commit f8db2b370fb5 · 2023-12-20T17:14:29.000+07:00
diff --git a/src/BaseQueryBuilderExtend.php b/src/BaseQueryBuilderExtend.php
@@ -104,7 +104,11 @@ public function delete(): int
      */
     public function with(array|string $relations, Closure|null|string $callback = null): BaseQueryBuilder
     {
-        $this->builder->with($relations, $callback);
+        if (is_null($callback)) {
+            $this->builder->with($relations);
+        } else {
+            $this->builder->with($relations, $callback);
+        }
         return $this->baseQueryBuilder;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,11 @@ public function delete(): int`
`104`	`104`	`*/`
`105`	`105`	`public function with(array\|string $relations, Closure\|null\|string $callback = null): BaseQueryBuilder`
`106`	`106`	`{`
`107`		`- $this->builder->with($relations, $callback);`
	`107`	`+ if (is_null($callback)) {`
	`108`	`+ $this->builder->with($relations);`
	`109`	`+ } else {`
	`110`	`+ $this->builder->with($relations, $callback);`
	`111`	`+ }`
`108`	`112`	`return $this->baseQueryBuilder;`
`109`	`113`	`}`
`110`	`114`