Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button color accessibility #757

Open
tdy opened this issue Dec 14, 2023 · 1 comment
Open

Button color accessibility #757

tdy opened this issue Dec 14, 2023 · 1 comment

Comments

@tdy
Copy link
Collaborator

tdy commented Dec 14, 2023 •
edited
Loading

Some buttons have insufficient text contrast. For some reason we have two different button implementations:

  1. Enough contrast: Styled automatically via src/layouts/CTButtons/styles.js
  2. Not enough contrast: Styled manually via src/components/stylesheets/general.vars.css

We could fix option 2 in isolation, but ideally we would just unify all buttons to use option 1.
@angrave
Copy link
Collaborator

angrave commented Jan 5, 2024

@tdy I've recently updated general.vars and made other changes; it is possible that this issue is now fixed..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdy @angrave