Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Reasonable MaxPool and other DB connection properties #105

Open
angrave opened this issue Sep 28, 2020 · 0 comments
Open

Set Reasonable MaxPool and other DB connection properties #105

angrave opened this issue Sep 28, 2020 · 0 comments
Assignees
@robkooper @angrave

Comments

@angrave
Copy link
Collaborator

angrave commented Sep 28, 2020

What should DB connection string be for the WebAPI and TaskEngine?

In the database connection string,we hrad code "MaxPoolSize=1000" but this is larger than the number of connections than the database is configured for (500 IIRC).

This setting is currently used in both the API and TaskEngine - it should be possible to split these up.

Any other parameters we should be setting?

On the code side, we will leave the password, username etc as explicit parameters, but support two environment variables,
"TASKENGINE_DB_CONNECTION_EXTRAS" and "WEBSERVER_DB_CONNECTION_EXTRAS"

  • but what values should they have?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robkooper robkooper

@angrave angrave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robkooper @angrave