Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

denormalize page-list users #38

Open
nelsonpecora opened this issue Nov 29, 2017 · 0 comments
Open

denormalize page-list users #38

nelsonpecora opened this issue Nov 29, 2017 · 0 comments
Assignees

Comments

@nelsonpecora
Copy link
Contributor

nelsonpecora commented Nov 29, 2017

Problem

Currently, the users in each page in the page list include all of their data, not just an ID to look them up. This means that any changes made to the user data will not reflect on old pages, and makes the search mappings brittle.

Solution

Instead, we should store an array of { id, updateTime }, where each id is the <base64:username@provider> of the user. This would allow Kiln to always display the most up-to-date user information, and would remove some of the sanitization code around updating the page list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants