Decrease flakyness when switching account

Author: LauraBeatris

integration/tests/session-tasks-multi-session.test.ts

@@ -80,7 +80,8 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withSessionTasks] })(
       await u.po.userButton.waitForMounted();
       await u.po.userButton.toggleTrigger();
       await u.po.userButton.waitForPopover();
-      await u.po.userButton.switchAccount(user2.firstName);
+      await u.po.userButton.toHaveVisibleMenuItems([/Manage account/i, /Sign out$/i]);
+      await u.po.userButton.switchAccount(user2.email);
 
       // Resolve task
       await u.page.waitForAppUrl('/sign-in/tasks/add-organization');

packages/testing/src/playwright/unstable/page-objects/userButton.ts

@@ -32,11 +32,12 @@ export const createUserButtonPageObject = (testArgs: { page: EnhancedPage }) =>
     triggerManageAccount: () => {
       return page.getByRole('menuitem', { name: /Manage account/i }).click();
     },
-    switchAccount: (username: string) => {
-      return page
+    switchAccount: async (emailAddress: string) => {
+      const menuItem = page
         .getByRole('menuitem')
-        .filter({ has: page.locator('span', { hasText: username }) })
-        .click();
+        .filter({ has: page.locator('span', { hasText: new RegExp(emailAddress) }) });
+      await menuItem.waitFor({ state: 'attached' });
+      return menuItem.click();
     },
   };