SphereTransform: center coords are not relative

[imagejan]

The arguments to SphereTransform are called relative_center_{xyz}, but the call to ReslicePolar.reslice is performing translation in pixel units, without any normalization:

clij2/src/main/java/net/haesleinhuepf/clij2/plugins/SphereTransform.java

Lines 54 to 59 in 5c716fb

	ReslicePolar.reslicePolar(clij2, pushed, result,
	delta_angle_in_degrees, 0f, 0f,
	relative_center_x, relative_center_y, relative_center_z,
	1f, 1f, 1f,
	0f, 0f, 0f,
	0f, 0f, 0f);

clij2/src/main/java/net/haesleinhuepf/clij2/plugins/ReslicePolar.java

Lines 75 to 76 in 5c716fb

	public static boolean reslicePolar(CLIJ2 clij2, ClearCLBuffer src, ClearCLBuffer dst, Float deltaAngle, Float startInclinationDegrees, Float startAzimuthDegrees, Float centerX, Float centerY, Float centerZ, Float scaleFactorX, Float scaleFactorY, Float scaleFactorZ,
	float translation_x, float translation_y, float translation_z, float rotation_x, float rotation_y, float rotation_z) {

I'd suggest to either rename the arguments to center_{xyz}, or to (re-)introduce some normalization to image dimensions before that call.

[imagejan]

For completeness: when running the plugin via clij{2,x}-assistant, the arguments are indeed relative. Normalization of the relative coordinates is currently happening in two places, before calling the underlying CLIJ2 plugin with absolute coordinates:

https://github.com/clij/clij2-assistant/blob/1cef95e60735399c994c7e3186b1c2aa03059c5d/src/main/java/net/haesleinhuepf/clij2/assistant/interactive/handcrafted/SphereTransform.java#L78

https://github.com/clij/clijx-assistant/blob/6b6c719098179ee3fe6afa6317aba0b6d70d927a/src/main/java/net/haesleinhuepf/clijx/assistant/interactive/handcrafted/SphereTransform.java#L78