Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to suggestions #107

Open
danielcompton opened this issue Nov 9, 2014 · 1 comment
Open

Add metadata to suggestions #107

danielcompton opened this issue Nov 9, 2014 · 1 comment

Comments

@danielcompton
Copy link
Member

Kibit makes suggestions that are valid most of the time but are not always exactly equivalent. #83 is a good example of this, where into [] and vec behave differently when used with core.reducers. I think it would be useful to be able to add comments to rules to explain these caveats.

There are also new Clojure forms that were introduced in 1.6. It would be good to check the version of Clojure the project is running on and only present rules that are valid on their version of Clojure.

@danielcompton danielcompton changed the title Suggestion comments Add comments to suggestions Nov 9, 2014
@danielcompton danielcompton changed the title Add comments to suggestions Add metadata to suggestions Nov 11, 2014
@yogsototh
Copy link
Contributor

Also, (not (empty? x)) is not always equivalent to (seq x) (the same for (when-not (empty? x) ...) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants