Skip to content

Commit 1d04930

Browse files
authored
remove module watcher from subscription (#3602)
# Description of Changes Problem is visible in replication smoketests, which exit and re-lauch modules, erorring out with: ``` ERROR /app/public/crates/core/src/host/host_controller.rs:818: Failed to open database: DatabaseError: Database is already opened. Path:`/stdb/data/replicas/4`. Error:Resource temporarily unavailable (os error 11).: Database is already opened. Path:`/stdb/data/replicas/4`. Error:Resource temporarily unavailable (os error 11) ``` Commented code will be a blocker for releasing Views but we want CIs to pass.
1 parent 8307d7c commit 1d04930

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

crates/core/src/host/host_controller.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -886,7 +886,11 @@ impl Host {
886886
let disk_metrics_recorder_task = tokio::spawn(metric_reporter(replica_ctx.clone())).abort_handle();
887887

888888
let module = watch::Sender::new(module_host);
889-
replica_ctx.subscriptions.init(module.subscribe());
889+
//TODO(shub): Below code interfere with `exit_module` code,
890+
// I suspect channel internally holds a reference to the module,
891+
// even after we drop the sender.
892+
//
893+
// replica_ctx.subscriptions.init(module.subscribe());
890894
Ok(Host {
891895
module,
892896
replica_ctx,

0 commit comments

Comments
 (0)