Remove usages of first' and second' from cl

Author: bbatsov

cider-client.el

@@ -258,7 +258,7 @@ loaded. If CALLBACK is nil, use `cider-load-file-handler'."
     (when err
       ;; err will be a stacktrace with a first line that looks like:
       ;; "clojure.lang.ExceptionInfo: Unmatched delimiter ]"
-      (error (first (split-string err "\n"))))
+      (error (car (split-string err "\n"))))
     (nrepl-dict-get response "formatted-edn")))
 
 (provide 'cider-client)

cider-interaction.el

@@ -1018,7 +1018,7 @@ form, with symbol at point replaced by __prefix__."
 
 (defun cider-completion--get-candidate-type (symbol)
   (let ((type (get-text-property 0 'type symbol)))
-    (or (cl-second (assoc type cider-completion-annotations-alist))
+    (or (cadr (assoc type cider-completion-annotations-alist))
         type)))
 
 (defun cider-completion--get-candidate-ns (symbol)

cider-stacktrace.el

@@ -459,12 +459,12 @@ it wraps to 0."
   (with-current-buffer buffer
     (insert "  Show: ")
     (dolist (filter filters)
-      (insert-text-button (first filter)
-                          'filter (second filter)
+      (insert-text-button (car filter)
+                          'filter (cadr filter)
                           'follow-link t
                           'action 'cider-stacktrace-filter
                           'help-echo (format "Toggle %s stack frames"
-                                             (first filter)))
+                                             (car filter)))
       (insert " "))
     (let ((hidden "(0 frames hidden)"))
       (put-text-property 0 (length hidden) 'hidden-count t hidden)
@@ -534,7 +534,7 @@ This associates text properties to enable filtering and source navigation."
   "Set and apply CAUSES initial visibility, filters, and cursor position."
   ;; Partially display outermost cause if it's a compiler exception (the
   ;; description reports reader location of the error).
-  (nrepl-dbind-response (first causes) (class)
+  (nrepl-dbind-response (car causes) (class)
     (when (equal class "clojure.lang.Compiler$CompilerException")
       (cider-stacktrace-cycle-cause (length causes) 1)))
   ;; Fully display innermost cause. This also applies visibility/filters.

cider-test.el

@@ -469,7 +469,7 @@ is searched."
         (cider-test-execute ns nil (list var))
       (let ((ns  (clojure-find-ns))
             (def (clojure-find-def)))
-        (if (and ns (member (first def) '("deftest" "defspec")))
+        (if (and ns (member (car def) '("deftest" "defspec")))
             (cider-test-execute ns nil (rest def))
           (message "No test at point"))))))
 

cider.el

@@ -264,7 +264,7 @@ Return a list of the form (HOST PORT), where PORT can be nil."
          (sel-port (completing-read (format "Port for %s: " host) ports
                                     nil nil nil nil (caar ports)))
          (port (or (cdr (assoc sel-port ports)) sel-port))
-         (port (if (listp port) (second port) port)))
+         (port (if (listp port) (cadr port) port)))
     (if (stringp port) (string-to-number port) port)))
 
 (defun cider-locate-running-nrepl-ports (&optional dir)

test/cider-tests.el

@@ -213,7 +213,7 @@
                              (buffer-string)))
               (goto-char 80)         ; somewhere in the second connection listed
               (nrepl-connections-make-default)
-              (should (equal (buffer-name b2) (first nrepl-connection-list)))
+              (should (equal (buffer-name b2) (car nrepl-connection-list)))
               (should (equal "  Host              Port   Project
 
   localhost         4005   proj