Skip to content

Notify users when some command is not supported under ClojureScript #2198

Open
@bbatsov

Description

@bbatsov
Member

Right now often people experience weird issues when they try to run something supported only for Clojure in a ClojureScript connection. It'd be nice if we added some basic function that does sanity checking in such commands and informs the users that the command they won't to use is not yet supporting "ClojureScript". Back in the day we've added some check only for the debugger, but it's time to expand this.

This command should be pretty easy to implement and should be applied to common interactive commands.

Any volunteers to take a stab at it? @xiongtx @ckoparkar @dpsutton

Activity

ckoparkar

ckoparkar commented on Feb 6, 2018

@ckoparkar

I'll be happy to take a look at this in the next few days.

ckoparkar

ckoparkar commented on Feb 14, 2018

@ckoparkar

Update: Started looking at this yesterday. Will post a PR before the weekend.

bbatsov

bbatsov commented on Feb 14, 2018

@bbatsov
MemberAuthor

Awesome!

bbatsov

bbatsov commented on Feb 27, 2018

@bbatsov
MemberAuthor

@ckoparkar How's that PR coming along?

ckoparkar

ckoparkar commented on Feb 27, 2018

@ckoparkar

Sorry, got distracted with other things :( Will finish this up soon.

bbatsov

bbatsov commented on Mar 4, 2018

@bbatsov
MemberAuthor

No problem!

bbatsov

bbatsov commented on Apr 2, 2018

@bbatsov
MemberAuthor

@ckoparkar Any progress with this? I hope to push a new release out in about 2 weeks and it'd be awesome if this is part of it.

ckoparkar

ckoparkar commented on Apr 4, 2018

@ckoparkar

Huh, it's been 2 months since my first comment. Really sorry for squatting on this for so long. Unfortunately, I din't get a lot of time to work on this :(

@dpsutton @xiongtx does this sound like something you'd like to pick up? If not, I'm going to try and finish it up over the weekend. I'd hate for this to miss the release.

bbatsov

bbatsov commented on Apr 4, 2018

@bbatsov
MemberAuthor

@ckoparkar I'm fine with waiting till the weekend.

added
good first issueA simple tasks suitable for first-time contributors
and removed
good first issueA simple tasks suitable for first-time contributors
on May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @bbatsov@ckoparkar

        Issue actions

          Notify users when some command is not supported under ClojureScript · Issue #2198 · clojure-emacs/cider