CLJS-2407: Add docstrings for map and positional factory functions

Author: mfikes

src/main/clojure/cljs/core.cljc

@@ -1676,8 +1676,10 @@
   [rsym rname fields]
   (core/let [fn-name (with-meta (symbol (core/str '-> rsym))
                        (assoc (meta rsym) :factory :positional))
+             docstring (core/str "Positional factory function for " rname ".")
         field-values (if (core/-> rsym meta :internal-ctor) (conj fields nil nil nil) fields)]
     `(defn ~fn-name
+       ~docstring
        [~@fields]
        (new ~rname ~@field-values))))
 
@@ -1859,10 +1861,11 @@
 (core/defn- build-map-factory [rsym rname fields]
   (core/let [fn-name (with-meta (symbol (core/str 'map-> rsym))
                        (assoc (meta rsym) :factory :map))
+             docstring (core/str "Factory function for " rname ", taking a map of keywords to field values.")
              ms (gensym)
              ks (map keyword fields)
              getters (map (core/fn [k] `(~k ~ms)) ks)]
-    `(defn ~fn-name [~ms]
+    `(defn ~fn-name ~docstring [~ms]
        (new ~rname ~@getters nil (not-empty (dissoc ~ms ~@ks)) nil))))
 
 (core/defmacro defrecord

src/test/cljs/cljs/core_test.cljs

@@ -1483,6 +1483,14 @@
   (is (= "##Inf" (pr-str js/Infinity)))
   (is (= "##-Inf" (pr-str js/-Infinity))))
 
+(deftype Foo2407 [x y])
+(defrecord Bar2407 [x y])
+
+(deftest test-cljs-2407
+  (is (= "Positional factory function for cljs.core-test/Foo2407." (:doc (meta #'->Foo2407))))
+  (is (= "Positional factory function for cljs.core-test/Bar2407." (:doc (meta #'->Bar2407))))
+  (is (= "Factory function for cljs.core-test/Bar2407, taking a map of keywords to field values." (:doc (meta #'map->Bar2407)))))
+
 (comment
   ;; ObjMap
   ;; (let [ks (map (partial str "foo") (range 500))