Skip to content

Sorting not returned with defaultSorting  #290

Open
@lucianholt97

Description

@lucianholt97
Contributor

When I don't specify sorting in the request, but have defaultSorting set in the Adapter, the response does not contain the meta.sorting object. Therefor my js table does not know the sorting...

Is there any way I can fix it or is it a bug?

Activity

lindyhopchris

lindyhopchris commented on Jan 31, 2019

@lindyhopchris
Member

Hi!

the meta.sorting object

Not sure what you mean by this? There is no defined meta sorting object.

I think your question is related to #225 - is that what you're looking for?

lucianholt97

lucianholt97 commented on Jan 31, 2019

@lucianholt97
ContributorAuthor

Thank you for your quick reply!
It is not quite what I am looking for.
In my mind, the default sorting should be set on the server an not in JS. Therefor it would be handy if the api attached the sorting object to the meta data.
A workaround like you linked is not quite nice... I think the sorting data is as essential as the pagination data.

lindyhopchris

lindyhopchris commented on Feb 1, 2019

@lindyhopchris
Member

Ah I more meant that #225 was about being able to set meta from multiple places - including being able to pass meta out of the adapter (which at the moment is only allowed for pagination).

I totally agree with you, the developer should be able to return meta from the adapter. I think this will be solved when I solve #225 in a future version. At the moment it's not possible so the safest thing for you to do is to always send a sort parameter from the client (Javascript) so that your Javascript always knows what the sort order is.

added this to the 1.1.0 milestone on Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @lindyhopchris@lucianholt97

        Issue actions

          Sorting not returned with defaultSorting · Issue #290 · cloudcreativity/laravel-json-api