Skip to content

Commit 3ca64eb

Browse files
authored
Merge pull request #1315 from stokpop/fix/integration-test-assertions-pr1288
fix(tests): correct SapMachine and Tomcat version assertion strings
2 parents 7b46997 + ef6af9c commit 3ca64eb

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

src/integration/java_main_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ func testJavaMain(platform switchblade.Platform, fixtures string) func(*testing.
126126

127127
// Verify SAPMachine JRE was installed from manifest
128128
Expect(logs.String()).To(ContainSubstring("Java Buildpack"))
129-
Expect(logs.String()).To(ContainSubstring("Installing SAP Machine"))
129+
Expect(logs.String()).To(ContainSubstring("Installing SapMachine"))
130130
Expect(logs.String()).To(ContainSubstring("17."))
131131
})
132132
})

src/integration/tomcat_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ func testTomcat(platform switchblade.Platform, fixtures string) func(*testing.T,
171171
Expect(err).NotTo(HaveOccurred(), logs.String)
172172

173173
Expect(logs.String()).To(ContainSubstring("Installing OpenJDK (8."))
174-
Expect(logs.String()).To(ContainSubstring("Tomcat 9"))
174+
Expect(logs.String()).To(ContainSubstring("Installed Tomcat (9."))
175175
Eventually(deployment).Should(matchers.Serve(ContainSubstring("OK")))
176176
})
177177

@@ -185,7 +185,7 @@ func testTomcat(platform switchblade.Platform, fixtures string) func(*testing.T,
185185
Expect(err).NotTo(HaveOccurred(), logs.String)
186186

187187
Expect(logs.String()).To(ContainSubstring("Installing OpenJDK (11."))
188-
Expect(logs.String()).To(ContainSubstring("Tomcat 9"))
188+
Expect(logs.String()).To(ContainSubstring("Installed Tomcat (9."))
189189
Eventually(deployment).Should(matchers.Serve(ContainSubstring("OK")))
190190
})
191191

@@ -198,7 +198,7 @@ func testTomcat(platform switchblade.Platform, fixtures string) func(*testing.T,
198198
Expect(err).NotTo(HaveOccurred(), logs.String)
199199

200200
Expect(logs.String()).To(ContainSubstring("Installing OpenJDK (17."))
201-
Expect(logs.String()).To(ContainSubstring("Tomcat 9"))
201+
Expect(logs.String()).To(ContainSubstring("Installed Tomcat (9."))
202202
Eventually(deployment).Should(matchers.Serve(ContainSubstring("OK")))
203203
})
204204

@@ -224,7 +224,7 @@ func testTomcat(platform switchblade.Platform, fixtures string) func(*testing.T,
224224
Expect(err).NotTo(HaveOccurred(), logs.String)
225225

226226
Expect(logs.String()).To(ContainSubstring("Installing OpenJDK (11."))
227-
Expect(logs.String()).To(ContainSubstring("Tomcat 10"))
227+
Expect(logs.String()).To(ContainSubstring("Installed Tomcat (10."))
228228
Eventually(deployment).Should(matchers.Serve(ContainSubstring("OK")))
229229
})
230230

@@ -237,7 +237,7 @@ func testTomcat(platform switchblade.Platform, fixtures string) func(*testing.T,
237237
Expect(err).NotTo(HaveOccurred(), logs.String)
238238

239239
Expect(logs.String()).To(ContainSubstring("Installing OpenJDK (17."))
240-
Expect(logs.String()).To(ContainSubstring("Tomcat 10"))
240+
Expect(logs.String()).To(ContainSubstring("Installed Tomcat (10."))
241241
Eventually(deployment).Should(matchers.Serve(ContainSubstring("OK")))
242242
})
243243
})
@@ -258,7 +258,7 @@ func testTomcat(platform switchblade.Platform, fixtures string) func(*testing.T,
258258
Expect(err).NotTo(HaveOccurred(), logs.String)
259259

260260
Expect(logs.String()).To(ContainSubstring("Installing OpenJDK (17."))
261-
Expect(logs.String()).To(ContainSubstring("Tomcat 10.1."))
261+
Expect(logs.String()).To(ContainSubstring("Installed Tomcat (10.1."))
262262
Eventually(deployment).Should(matchers.Serve(ContainSubstring("OK")))
263263
})
264264
})
@@ -371,7 +371,7 @@ func testTomcat(platform switchblade.Platform, fixtures string) func(*testing.T,
371371

372372
Expect(err).NotTo(HaveOccurred(), logs.String)
373373

374-
Expect(logs.String()).To(ContainSubstring("Installing SAP Machine (17."))
374+
Expect(logs.String()).To(ContainSubstring("Installing SapMachine (17."))
375375
Eventually(deployment).Should(matchers.Serve(ContainSubstring("OK")))
376376
})
377377

@@ -384,7 +384,7 @@ func testTomcat(platform switchblade.Platform, fixtures string) func(*testing.T,
384384

385385
Expect(err).NotTo(HaveOccurred(), logs.String)
386386

387-
Expect(logs.String()).To(ContainSubstring("Installing SAP Machine (21."))
387+
Expect(logs.String()).To(ContainSubstring("Installing SapMachine (21."))
388388
Eventually(deployment).Should(matchers.Serve(ContainSubstring("OK")))
389389
})
390390

@@ -397,7 +397,7 @@ func testTomcat(platform switchblade.Platform, fixtures string) func(*testing.T,
397397

398398
Expect(err).NotTo(HaveOccurred(), logs.String)
399399

400-
Expect(logs.String()).To(ContainSubstring("Installing SAP Machine (25."))
400+
Expect(logs.String()).To(ContainSubstring("Installing SapMachine (25."))
401401
Eventually(deployment).Should(matchers.Serve(ContainSubstring("OK")))
402402
})
403403
})

0 commit comments

Comments
 (0)