Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GetServiceBinding to the broker client #3816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ddraganovv
Copy link
Contributor

Is there a related GitHub Issue?

Issue

What is this change about?

This is 2 of 2 PRs related to the above issue. With this PR there is a new handler implemented to the service binding endpoints - "/v3/service_credential_bindings/{guid}/parameters"

Does this PR introduce a breaking change?

No

@ddraganovv ddraganovv force-pushed the sb_parameters_endpoint branch from 0402c92 to 0898930 Compare February 21, 2025 01:36
@ddraganovv ddraganovv force-pushed the sb_parameters_endpoint branch from 0898930 to 984350f Compare February 24, 2025 08:54
Copy link
Member

@georgethebeatle georgethebeatle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some inline comments. Most importantly I believe the v3 API contract is violated.

@ddraganovv ddraganovv force-pushed the sb_parameters_endpoint branch 2 times, most recently from d8549b1 to 1440f2c Compare February 25, 2025 11:46
@ddraganovv ddraganovv force-pushed the sb_parameters_endpoint branch from 1440f2c to daf1ffe Compare February 27, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants