Making route controller optional enabling customizing of route controllers #3828
+34
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dariquest
changed the title
danail-branekov
previously approved these changes
Feb 27, 2025
auto-merge was automatically disabled
February 27, 2025 15:22
Head branch was pushed to by a user without write access
danail-branekov
previously approved these changes
Feb 27, 2025
danail-branekov
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
This change makes cf routing controller optional. A boolean controller config property "DisableRouteController" was introduced for it. It allows to define custom routing controllers in future.
Does this PR introduce a breaking change?
The default value of the boolean config property "DisableRouteController" is false, so everything stays the same, for those using default routing controller.
Acceptance Steps
make generate
make test