Remove redundant eventually statements in e2e tests #3829
+57
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
force-pushed
the
pr-fix-flake-bind-service
branch
2 times, most recently
from
ee25811 to
a1321cb
Compare
georgethebeatle
changed the title
georgethebeatle
force-pushed
the
pr-fix-flake-bind-service
branch
from
a1321cb to
203eda7
Compare
georgethebeatle
changed the title
Bonus improvements - introdude new utility finctions for app start and restart - introduce utility to get the app response as a json object
- There is no java buildpack on kind, as we use a minimal builder there - Improve the test check to check for the presence of a stack field, something characteristic for all buildpacks, rather than rely on a specific name to avoid such issues in future
danail-branekov
approved these changes
Feb 27, 2025
georgethebeatle
force-pushed
the
pr-fix-flake-bind-service
branch
from
203eda7 to
7393b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Remove redundant eventually statements in e2e tests
Bonus improvements