Skip to content

Commit 26d1982

Browse files
committed
chore: fix CI errors
1 parent b8890b8 commit 26d1982

File tree

4 files changed

+1032
-2154
lines changed

4 files changed

+1032
-2154
lines changed

.travis.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
sudo: false
22

3-
dist: trusty
3+
dist: bionic
44

55
language: node_js
66
node_js:
@@ -11,12 +11,17 @@ addons:
1111
apt:
1212
packages:
1313
- libgconf-2-4
14+
chrome: stable
1415

1516
cache:
1617
directories:
1718
- ~/.cache
1819
- node_modules
1920

21+
before_install:
22+
- curl -o- -L https://yarnpkg.com/install.sh | bash
23+
- export PATH="$HOME/.yarn/bin:$PATH"
24+
2025
install:
2126
- yarn --frozen-lockfile --non-interactive --no-progress
2227

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"lib:build:prod": "yarn run ng build --project ngx-sub-form",
2424
"lib:build:watch": "yarn run lib:build:prod --watch",
2525
"lib:test:watch": "yarn run ng test --project ngx-sub-form",
26-
"lib:test:ci": "yarn run ng test --project ngx-sub-form --watch false",
26+
"lib:test:ci": "yarn run ng test --project ngx-sub-form --watch false --browsers=ChromeHeadless",
2727
"------------------ Quick Commands ------------------": "",
2828
"lint:fix": "yarn demo:lint:fix && yarn prettier:write",
2929
"semantic-release": "semantic-release",
@@ -55,9 +55,9 @@
5555
"zone.js": "0.10.2"
5656
},
5757
"devDependencies": {
58-
"@angular-devkit/build-angular": "0.900.2",
59-
"@angular-devkit/build-ng-packagr": "0.900.2",
60-
"@angular/cli": "9.0.2",
58+
"@angular-devkit/build-angular": "0.900.1",
59+
"@angular-devkit/build-ng-packagr": "0.900.1",
60+
"@angular/cli": "9.0.1",
6161
"@angular/compiler-cli": "9.0.1",
6262
"@angular/language-service": "9.0.1",
6363
"@bahmutov/add-typescript-to-cypress": "2.1.2",

projects/ngx-sub-form/src/lib/ngx-automatic-root-form.component.spec.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,10 @@ describe(`NgxAutomaticRootFormComponent`, () => {
112112
componentFixture.detectChanges();
113113

114114
setTimeout(() => {
115-
expect(vehicleUpdatedSpy).toHaveBeenCalledWith(getNewCorrectValues());
115+
// todo: after upgrading to ng 9 + all the deps the following
116+
// is typed from chai instead of jasmine and it triggers errors
117+
// it shouldn't block the new release though
118+
(expect(vehicleUpdatedSpy) as any).toHaveBeenCalledWith(getNewCorrectValues());
116119
done();
117120
}, 0);
118121
});
@@ -125,13 +128,19 @@ describe(`NgxAutomaticRootFormComponent`, () => {
125128
componentFixture.detectChanges();
126129

127130
setTimeout(() => {
128-
expect(vehicleUpdatedSpy).not.toHaveBeenCalled();
131+
// todo: after upgrading to ng 9 + all the deps the following
132+
// is typed from chai instead of jasmine and it triggers errors
133+
// it shouldn't block the new release though
134+
(expect(vehicleUpdatedSpy) as any).not.toHaveBeenCalled();
129135

130136
componentForm.formGroupControls.crewMemberCount.setValue(MAX_CREW_MEMBER_COUNT);
131137
// shouldn't require to call `componentForm.manualSave()`!
132138

133139
setTimeout(() => {
134-
expect(vehicleUpdatedSpy).toHaveBeenCalledWith({
140+
// todo: after upgrading to ng 9 + all the deps the following
141+
// is typed from chai instead of jasmine and it triggers errors
142+
// it shouldn't block the new release though
143+
(expect(vehicleUpdatedSpy) as any).toHaveBeenCalledWith({
135144
...getNewIncorrectValues(),
136145
crewMemberCount: MAX_CREW_MEMBER_COUNT,
137146
});

0 commit comments

Comments
 (0)