v1.413.0

[spa-s3-cloudfront] Fix preview enviornments @goruha (#995)

what

• [spa-s3-cloudfront] Fix preview environments

why

• Preview envs required x-forwarded-host that is set by paywall lambdas. When the paywall is disabled, the preview still needs to work correctly.

v1.412.0

Use native cloudfront 404 page @goruha (#991)

what

• Use native Cloudfront 404 page configuration

why

• Lambda Edge to generate 404-page cost too much

references

• https://cloudposse.atlassian.net/browse/DEV-1707

v1.411.0

remove unused vars in `aws-backup` component to reflect the module upgrade @oycyc (#992)

what

After the AWS Backup module https://github.com/cloudposse/terraform-aws-backup/ 1.0 release, there's a couple of unused variables and unused logic, and some information that should be updated in the README.

• The variables schedule, start_window, completion_window, cold_storage_after, delet_after, and destination_vault_arn, etc. were removed as of the module's v0.14 and placed in deprecation (see PR https://github.com/cloudposse/terraform-aws-backup/pull/39/files#diff-0c2612bc0fbe3bc116da52a6aece40330dc93c8cbc640dc96427bf940f08f7c3) then finally removed entirely when the v1.0 release (see this PR by @Benbentwo : cloudposse/terraform-aws-backup#63)
  • They were moved to the rules object to support multiple plans, so getting rid of them in this component since they're not used anywhere anymore.
• Because the destination_vault and related variables aren't used on the top level (moved to the rule object like the others), the remote-state.tf file and the locals block that dynamically determines if the copy action is enabled is not used anymore either here.

Also updated the README to reflect these changes along with the new method for cross region copying.

why

Unused variables taking up space & tflint complaining 😅

Also an existing issue for this: #977

references

See links above for each point.

v1.410.0

Feat/add macie @mcalhoun (#790)

what

• Add the AWS Macie component

why

• To upstream the component developed for a customer

v1.409.0

chore: ecs-service policies should allow tagging now @dudymas (#994)

what

• add ecs:TagResource permission to policies

why

• changes to ECS policies mean that Task definitions can't have tagging
  details without a policy update

references

• Tag Resource permissions in
  ECS

v1.408.0

feat: Philips Labs GitHub Runners Alternate Instance Types @milldr (#990)

what

• Added variables for instance_target_capacity_type and create_service_linked_role_spot
• Fixed all tflint errors and warnings

why

• Support alternate instance type

Warning: [Fixable] local.lambda_repo is declared but not used (terraform_unused_declarations)
Warning: [Fixable] variable "lambda_repo_url" is declared but not used (terraform_unused_declarations)
Warning: [Fixable] variable "instance_types" is declared but not used (terraform_unused_declarations)
Warning: [Fixable] variable "repository_white_list" is declared but not used (terraform_unused_declarations)

references

• Internal slack

v1.407.0

`philips-labs-github-runners` install terraform docs @Benbentwo (#989)

what

• install terraform-docs on philips labs runners by default

why

required for many of our actions

v1.406.0

update `ecs` and add `cloudmap-namespace` component @Benbentwo (#984)

what

• New Cloudmap namespace
• integration with ECS

v1.405.0

chore: bumped `alb` module version @milldr (#988)

what

• Upgraded the alb module version in the alb component

why

• Use our latest module with the component

references

• n/a

v1.404.0

fix: ECS Cluster @milldr (#987)

what

• Fixed ACM Certificate lookup
• Upgrade alb module
• Resolve all tflint warnings

why

• The default ACM certificate should have the regional domain. ECS is a regional resource, and with our architecture we include the environment in the domain. TLDR the default should be use1.dev.plat.acme.com not dev.plat.acme.com
• Upgrade alb to use the latest included S3 module, with the updated requirements for adding S3 Bucket ACLs
• Support tflint

references

• customer engagement
• example tflint warnings:

Warning: [Fixable] List items should be accessed using square brackets (terraform_deprecated_index)

  on main.tf line 84:
  84:         security_group_ids          = concat(aws_security_group.default.*.id, provider.security_group_ids)

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_index.md

Warning: [Fixable] Comparing a collection with an empty list is invalid. To detect an empty collection, check its length. (terraform_empty_list_equality)

  on main.tf line 237:
 237:     "${config_key}_${domain}" => domain } if lookup(config, "additional_certs", []) != []

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_empty_list_equality.md

Warning: [Fixable] variable "default_capacity_strategy" is declared but not used (terraform_unused_declarations)

  on variables.tf line 236:
 236: variable "default_capacity_strategy" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_unused_declarations.md