Skip to content

Commit 996ceea

Browse files
georgylobkogeorgylobko
committed
feat: Report actual size for bottom drawer to correctly calc bottom offset for split panel
1 parent cb3d9de commit 996ceea

File tree

8 files changed

+73
-9
lines changed

8 files changed

+73
-9
lines changed

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@
177177
{
178178
"path": "lib/components/internal/widget-exports.js",
179179
"brotli": false,
180-
"limit": "966 kB",
180+
"limit": "967 kB",
181181
"ignore": "react-dom"
182182
}
183183
],

‎src/app-layout/__tests__/__snapshots__/widget-contract-old.test.tsx.snap‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ Map {
4242
"toolsClose": undefined,
4343
"toolsToggle": undefined,
4444
},
45+
"bottomDrawerReportedSize": 0,
4546
"bottomDrawersFocusControl": {
4647
"loseFocus": [Function],
4748
"refs": {
@@ -139,6 +140,7 @@ Map {
139140
"insetInlineEnd": 0,
140141
"insetInlineStart": 0,
141142
},
143+
"reportBottomDrawerSize": [Function],
142144
"setExpandedDrawerId": [Function],
143145
"setNotificationsHeight": [Function],
144146
"setToolbarHeight": [Function],
@@ -255,6 +257,7 @@ Map {
255257
"toolsClose": undefined,
256258
"toolsToggle": undefined,
257259
},
260+
"bottomDrawerReportedSize": 0,
258261
"bottomDrawersFocusControl": {
259262
"loseFocus": [Function],
260263
"refs": {
@@ -352,6 +355,7 @@ Map {
352355
"insetInlineEnd": 0,
353356
"insetInlineStart": 0,
354357
},
358+
"reportBottomDrawerSize": [Function],
355359
"setExpandedDrawerId": [Function],
356360
"setNotificationsHeight": [Function],
357361
"setToolbarHeight": [Function],
@@ -428,6 +432,7 @@ Map {
428432
"toolsClose": undefined,
429433
"toolsToggle": undefined,
430434
},
435+
"bottomDrawerReportedSize": 0,
431436
"bottomDrawersFocusControl": {
432437
"loseFocus": [Function],
433438
"refs": {
@@ -525,6 +530,7 @@ Map {
525530
"insetInlineEnd": 0,
526531
"insetInlineStart": 0,
527532
},
533+
"reportBottomDrawerSize": [Function],
528534
"setExpandedDrawerId": [Function],
529535
"setNotificationsHeight": [Function],
530536
"setToolbarHeight": [Function],
@@ -632,6 +638,7 @@ Map {
632638
"toolsClose": undefined,
633639
"toolsToggle": undefined,
634640
},
641+
"bottomDrawerReportedSize": 0,
635642
"bottomDrawersFocusControl": {
636643
"loseFocus": [Function],
637644
"refs": {
@@ -729,6 +736,7 @@ Map {
729736
"insetInlineEnd": 0,
730737
"insetInlineStart": 0,
731738
},
739+
"reportBottomDrawerSize": [Function],
732740
"setExpandedDrawerId": [Function],
733741
"setNotificationsHeight": [Function],
734742
"setToolbarHeight": [Function],
@@ -805,6 +813,7 @@ Map {
805813
"toolsClose": undefined,
806814
"toolsToggle": undefined,
807815
},
816+
"bottomDrawerReportedSize": 0,
808817
"bottomDrawersFocusControl": {
809818
"loseFocus": [Function],
810819
"refs": {
@@ -902,6 +911,7 @@ Map {
902911
"insetInlineEnd": 0,
903912
"insetInlineStart": 0,
904913
},
914+
"reportBottomDrawerSize": [Function],
905915
"setExpandedDrawerId": [Function],
906916
"setNotificationsHeight": [Function],
907917
"setToolbarHeight": [Function],
@@ -983,6 +993,7 @@ Map {
983993
"toolsClose": undefined,
984994
"toolsToggle": undefined,
985995
},
996+
"bottomDrawerReportedSize": 0,
986997
"bottomDrawersFocusControl": {
987998
"loseFocus": [Function],
988999
"refs": {
@@ -1086,6 +1097,7 @@ Map {
10861097
"insetInlineEnd": 0,
10871098
"insetInlineStart": 0,
10881099
},
1100+
"reportBottomDrawerSize": [Function],
10891101
"setExpandedDrawerId": [Function],
10901102
"setNotificationsHeight": [Function],
10911103
"setToolbarHeight": [Function],
@@ -1205,6 +1217,7 @@ Map {
12051217
"toolsClose": undefined,
12061218
"toolsToggle": undefined,
12071219
},
1220+
"bottomDrawerReportedSize": 0,
12081221
"bottomDrawersFocusControl": {
12091222
"loseFocus": [Function],
12101223
"refs": {
@@ -1308,6 +1321,7 @@ Map {
13081321
"insetInlineEnd": 0,
13091322
"insetInlineStart": 0,
13101323
},
1324+
"reportBottomDrawerSize": [Function],
13111325
"setExpandedDrawerId": [Function],
13121326
"setNotificationsHeight": [Function],
13131327
"setToolbarHeight": [Function],
@@ -1384,6 +1398,7 @@ Map {
13841398
"toolsClose": undefined,
13851399
"toolsToggle": undefined,
13861400
},
1401+
"bottomDrawerReportedSize": 0,
13871402
"bottomDrawersFocusControl": {
13881403
"loseFocus": [Function],
13891404
"refs": {
@@ -1487,6 +1502,7 @@ Map {
14871502
"insetInlineEnd": 0,
14881503
"insetInlineStart": 0,
14891504
},
1505+
"reportBottomDrawerSize": [Function],
14901506
"setExpandedDrawerId": [Function],
14911507
"setNotificationsHeight": [Function],
14921508
"setToolbarHeight": [Function],
@@ -1566,6 +1582,7 @@ Map {
15661582
"toolsClose": undefined,
15671583
"toolsToggle": undefined,
15681584
},
1585+
"bottomDrawerReportedSize": 0,
15691586
"bottomDrawersFocusControl": {
15701587
"loseFocus": [Function],
15711588
"refs": {
@@ -1669,6 +1686,7 @@ Map {
16691686
"insetInlineEnd": 0,
16701687
"insetInlineStart": 0,
16711688
},
1689+
"reportBottomDrawerSize": [Function],
16721690
"setExpandedDrawerId": [Function],
16731691
"setNotificationsHeight": [Function],
16741692
"setToolbarHeight": [Function],
@@ -1778,6 +1796,7 @@ Map {
17781796
"toolsClose": undefined,
17791797
"toolsToggle": undefined,
17801798
},
1799+
"bottomDrawerReportedSize": 0,
17811800
"bottomDrawersFocusControl": {
17821801
"loseFocus": [Function],
17831802
"refs": {
@@ -1881,6 +1900,7 @@ Map {
18811900
"insetInlineEnd": 0,
18821901
"insetInlineStart": 0,
18831902
},
1903+
"reportBottomDrawerSize": [Function],
18841904
"setExpandedDrawerId": [Function],
18851905
"setNotificationsHeight": [Function],
18861906
"setToolbarHeight": [Function],
@@ -1957,6 +1977,7 @@ Map {
19571977
"toolsClose": undefined,
19581978
"toolsToggle": undefined,
19591979
},
1980+
"bottomDrawerReportedSize": 0,
19601981
"bottomDrawersFocusControl": {
19611982
"loseFocus": [Function],
19621983
"refs": {
@@ -2060,6 +2081,7 @@ Map {
20602081
"insetInlineEnd": 0,
20612082
"insetInlineStart": 0,
20622083
},
2084+
"reportBottomDrawerSize": [Function],
20632085
"setExpandedDrawerId": [Function],
20642086
"setNotificationsHeight": [Function],
20652087
"setToolbarHeight": [Function],
@@ -2155,6 +2177,7 @@ Map {
21552177
"toolsClose": undefined,
21562178
"toolsToggle": undefined,
21572179
},
2180+
"bottomDrawerReportedSize": 0,
21582181
"bottomDrawersFocusControl": {
21592182
"loseFocus": [Function],
21602183
"refs": {
@@ -2254,6 +2277,7 @@ Map {
22542277
"insetInlineEnd": 0,
22552278
"insetInlineStart": 0,
22562279
},
2280+
"reportBottomDrawerSize": [Function],
22572281
"setExpandedDrawerId": [Function],
22582282
"setNotificationsHeight": [Function],
22592283
"setToolbarHeight": [Function],
@@ -2386,6 +2410,7 @@ Map {
23862410
"toolsClose": undefined,
23872411
"toolsToggle": undefined,
23882412
},
2413+
"bottomDrawerReportedSize": 0,
23892414
"bottomDrawersFocusControl": {
23902415
"loseFocus": [Function],
23912416
"refs": {
@@ -2485,6 +2510,7 @@ Map {
24852510
"insetInlineEnd": 0,
24862511
"insetInlineStart": 0,
24872512
},
2513+
"reportBottomDrawerSize": [Function],
24882514
"setExpandedDrawerId": [Function],
24892515
"setNotificationsHeight": [Function],
24902516
"setToolbarHeight": [Function],
@@ -2575,6 +2601,7 @@ Map {
25752601
"toolsClose": undefined,
25762602
"toolsToggle": undefined,
25772603
},
2604+
"bottomDrawerReportedSize": 0,
25782605
"bottomDrawersFocusControl": {
25792606
"loseFocus": [Function],
25802607
"refs": {
@@ -2674,6 +2701,7 @@ Map {
26742701
"insetInlineEnd": 0,
26752702
"insetInlineStart": 0,
26762703
},
2704+
"reportBottomDrawerSize": [Function],
26772705
"setExpandedDrawerId": [Function],
26782706
"setNotificationsHeight": [Function],
26792707
"setToolbarHeight": [Function],
@@ -2795,6 +2823,7 @@ Map {
27952823
"toolsClose": undefined,
27962824
"toolsToggle": undefined,
27972825
},
2826+
"bottomDrawerReportedSize": 0,
27982827
"bottomDrawersFocusControl": {
27992828
"loseFocus": [Function],
28002829
"refs": {
@@ -2894,6 +2923,7 @@ Map {
28942923
"insetInlineEnd": 0,
28952924
"insetInlineStart": 0,
28962925
},
2926+
"reportBottomDrawerSize": [Function],
28972927
"setExpandedDrawerId": [Function],
28982928
"setNotificationsHeight": [Function],
28992929
"setToolbarHeight": [Function],
@@ -2984,6 +3014,7 @@ Map {
29843014
"toolsClose": undefined,
29853015
"toolsToggle": undefined,
29863016
},
3017+
"bottomDrawerReportedSize": 0,
29873018
"bottomDrawersFocusControl": {
29883019
"loseFocus": [Function],
29893020
"refs": {
@@ -3083,6 +3114,7 @@ Map {
30833114
"insetInlineEnd": 0,
30843115
"insetInlineStart": 0,
30853116
},
3117+
"reportBottomDrawerSize": [Function],
30863118
"setExpandedDrawerId": [Function],
30873119
"setNotificationsHeight": [Function],
30883120
"setToolbarHeight": [Function],

0 commit comments

Comments
 (0)