Remove ideal issuer selection

Author: bricht

Api/Config/ConfigInterface.php

@@ -45,8 +45,6 @@ interface ConfigInterface
     public const XML_PATH_PAYMENT_GIFTCARD_PROFILE = 'payment/cm_payments_giftcard/profile';
     public const XML_PATH_PAYMENT_KLARNA_MANUAL_CAPTURE = 'payment/cm_payments_klarna/manual_capture';
     public const XML_PATH_PAYMENT_CM_PAYMENTS_PROFILE = 'payment/cm_payments/profile';
-    public const XML_PATH_PAYMENT_IDEAL_ENABLE_ISSUER_SELECTION = 'payment/cm_payments_ideal/enable_issuer_selection';
-
     /**
      * Checks that extension is enabled
      *
@@ -281,9 +279,4 @@ public function getAdjustmentFeeName(): ?string;
      * @return bool
      */
     public function isLogAllRestApiCalls(): bool;
-
-    /**
-     * @return bool
-     */
-    public function isIdealIssuerSelectionEnabled(): bool;
 }

Api/Data/IssuerInterface.php

@@ -17,26 +17,6 @@
  */
 interface PaymentMethodAdditionalDataInterface extends ExtensibleDataInterface
 {
-    /**
-     * Properties
-     */
-    public const ISSUERS = 'issuers';
-
-    /**
-     * Get issuers
-     *
-     * @return \CM\Payments\Api\Data\IssuerInterface[]
-     */
-    public function getIssuers(): array;
-
-    /**
-     * Set code
-     *
-     * @param \CM\Payments\Api\Data\IssuerInterface[] $issuers
-     * @return PaymentMethodAdditionalDataInterface
-     */
-    public function setIssuers(array $issuers): PaymentMethodAdditionalDataInterface;
-
     /**
      * Retrieve existing extension attributes object or create a new one.
      *

Api/Data/PaymentMethodAdditionalDataInterface.php

@@ -32,14 +32,4 @@ interface GuestPaymentMethodManagementInterface
      * @throws NoSuchEntityException
      */
     public function getPaymentMethods(string $cartId, ?AddressInterface $shippingAddress): PaymentDetailsInterface;
-
-    /**
-     * @param string $cartId
-     * @return \CM\Payments\Client\Api\IdealIssuerInterface[]|bool
-     *
-     * @throws InputException
-     * @throws StateException
-     * @throws NoSuchEntityException
-     */
-    public function getIbanIssuers(string $cartId);
 }

Api/GuestPaymentMethodManagementInterface.php

@@ -32,14 +32,4 @@ interface PaymentMethodManagementInterface
      * @throws NoSuchEntityException
      */
     public function getPaymentMethods(int $cartId, ?AddressInterface $shippingAddress): PaymentDetailsInterface;
-
-    /**
-     * @param int $cartId
-     * @return \CM\Payments\Client\Api\IdealIssuerInterface[]|bool
-     *
-     * @throws InputException
-     * @throws StateException
-     * @throws NoSuchEntityException
-     */
-    public function getIbanIssuers(int $cartId);
 }

Api/PaymentMethodManagementInterface.php

@@ -81,68 +81,6 @@ interface MethodServiceInterface
         ConfigProvider::CODE_KLARNA => 'KLARNA'
     ];
 
-    /**
-     * Mapping of magento ideal issuers
-     */
-    public const IDEAL_ISSUERS = [
-        [
-            'id' => 'BUNQNL2A',
-            'name' => 'bunq',
-        ],
-        [
-            'id' => 'ASNBNL21',
-            'name' => 'ASN Bank',
-        ],
-        [
-            'id' => 'RBRBNL21',
-            'name' => 'RegioBank',
-        ],
-        [
-            'id' => 'TRIONL2U',
-            'name' => 'Triodos Bank',
-        ],
-        [
-            'id' => 'FVLBNL22',
-            'name' => 'Van Lanschot',
-        ],
-        [
-            'id' => 'SNSBNL2A',
-            'name' => 'SNS Bank',
-        ],
-        [
-            'id' => 'KNABNL2H',
-            'name' => 'Knab',
-        ],
-        [
-            'id' => 'INGBNL2A',
-            'name' => 'ING',
-        ],
-        [
-            'id' => 'ABNANL2A',
-            'name' => 'ABN Amro',
-        ],
-        [
-            'id' => 'RABONL2U',
-            'name' => 'Rabobank'
-        ],
-        [
-            'id' => 'BITSNL2A',
-            'name' => 'Yoursafe'
-        ],
-        [
-            'id' => 'NNBANL2G',
-            'name' => 'Nationale-Nederlanden'
-        ],
-        [
-            'id' => 'NTSBDEB1',
-            'name' => 'N26'
-        ],
-        [
-            'id' => 'REVOLT21',
-            'name' => 'Revolut'
-        ]
-    ];
-
     /**
      * Get methods from CM and compare it with Magento methods
      * @param PaymentMethodInterface[] $magentoMethods

Api/Service/MethodServiceInterface.php

@@ -16,11 +16,6 @@ class PaymentCreate
      */
     private $method;
 
-    /**
-     * @var array
-     */
-    private $idealDetails;
-
     /**
      * @var array
      */
@@ -35,18 +30,15 @@ class PaymentCreate
      * Order constructor
      *
      * @param string $method
-     * @param array $idealDetails
      * @param array $elvDetails
      * @param CardDetails|null $cardDetails
      */
     public function __construct(
         string $method = '',
-        array $idealDetails = [],
         array $elvDetails = [],
         CardDetails $cardDetails = null
     ) {
         $this->method = $method;
-        $this->idealDetails = $idealDetails;
         $this->elvDetails = $elvDetails;
         $this->cardDetails = $cardDetails;
     }
@@ -62,10 +54,6 @@ public function toArray(): array
             'method' => $this->method
         ];
 
-        if ($this->idealDetails) {
-            $data['ideal_details'] = $this->idealDetails;
-        }
-
         if ($this->elvDetails) {
             $data['elv_payment_input'] = $this->elvDetails;
         }
@@ -93,22 +81,6 @@ public function setMethod(string $method): void
         $this->method = $method;
     }
 
-    /**
-     * @return array
-     */
-    public function getIdealDetails(): array
-    {
-        return $this->idealDetails;
-    }
-
-    /**
-     * @param array $idealDetails
-     */
-    public function setIdealDetails(array $idealDetails): void
-    {
-        $this->idealDetails = $idealDetails;
-    }
-
     /**
      * @return array
      */

Client/Api/IdealIssuerInterface.php

@@ -51,8 +51,14 @@ class RefundCreate
     /**
      * Order constructor
      *
-     * @param string $method
-     * @param array $idealDetails
+     * @param string $orderKey
+     * @param string $paymentId
+     * @param string $orderId
+     * @param string $description
+     * @param int $amount
+     * @param string $currency
+     * @param string $refundReference
+     * @param string $refundRequiredDate
      */
     public function __construct(
         string $orderKey,