Added option to not select ideal issuer in the magento checkout

Author: bricht

Api/Config/ConfigInterface.php

@@ -45,6 +45,7 @@ interface ConfigInterface
     public const XML_PATH_PAYMENT_GIFTCARD_PROFILE = 'payment/cm_payments_giftcard/profile';
     public const XML_PATH_PAYMENT_KLARNA_MANUAL_CAPTURE = 'payment/cm_payments_klarna/manual_capture';
     public const XML_PATH_PAYMENT_CM_PAYMENTS_PROFILE = 'payment/cm_payments/profile';
+    public const XML_PATH_PAYMENT_IDEAL_ENABLE_ISSUER_SELECTION = 'payment/cm_payments_ideal/enable_issuer_selection';
 
     /**
      * Checks that extension is enabled
@@ -280,4 +281,9 @@ public function getAdjustmentFeeName(): ?string;
      * @return bool
      */
     public function isLogAllRestApiCalls(): bool;
+
+    /**
+     * @return bool
+     */
+    public function isIdealIssuerSelectionEnabled(): bool;
 }

Api/GuestPaymentMethodManagementInterface.php

@@ -35,11 +35,11 @@ public function getPaymentMethods(string $cartId, ?AddressInterface $shippingAdd
 
     /**
      * @param string $cartId
-     * @return \CM\Payments\Client\Api\IdealIssuerInterface[]
+     * @return \CM\Payments\Client\Api\IdealIssuerInterface[]|bool
      *
      * @throws InputException
      * @throws StateException
      * @throws NoSuchEntityException
      */
-    public function getIbanIssuers(string $cartId): array;
+    public function getIbanIssuers(string $cartId);
 }

Api/PaymentMethodManagementInterface.php

@@ -35,11 +35,11 @@ public function getPaymentMethods(int $cartId, ?AddressInterface $shippingAddres
 
     /**
      * @param int $cartId
-     * @return \CM\Payments\Client\Api\IdealIssuerInterface[]
+     * @return \CM\Payments\Client\Api\IdealIssuerInterface[]|bool
      *
      * @throws InputException
      * @throws StateException
      * @throws NoSuchEntityException
      */
-    public function getIbanIssuers(int $cartId): array;
+    public function getIbanIssuers(int $cartId);
 }

Config/Config.php

@@ -514,6 +514,16 @@ public function getIsKlarnaManualCapture(): bool
         return $manualCapture === '1' || $manualCapture === true;
     }
 
+    public function isIdealIssuerSelectionEnabled(): bool
+    {
+        return $this->getConfig(
+            self::XML_PATH_PAYMENT_IDEAL_ENABLE_ISSUER_SELECTION,
+            ScopeInterface::SCOPE_STORES,
+            (string)$this->storeManager->getStore()->getId(),
+            true
+        );
+    }
+
     /**
      * Get config value by path
      *

Service/Payment/Request/Part/IdealDetails.php

@@ -29,9 +29,12 @@ public function process(
         }
 
         $value = $this->getSelectedIssuer($order);
-        $paymentCreate->setIdealDetails([
-            'issuer_id' => $value
-        ]);
+
+        if (!empty($value)) {
+            $paymentCreate->setIdealDetails([
+                'issuer_id' => $value
+            ]);
+        }
 
         return $paymentCreate;
     }

Webapi/GuestPaymentMethodManagement.php

@@ -55,7 +55,7 @@ public function getPaymentMethods(
     /**
      * {@inheritDoc}
      */
-    public function getIbanIssuers(string $cartId): array
+    public function getIbanIssuers(string $cartId)
     {
         $quoteId = $this->maskedQuoteIdToQuoteId->execute($cartId);
 

Webapi/PaymentMethodManagement.php

@@ -101,8 +101,12 @@ public function getPaymentMethods(
     /**
      * {@inheritDoc}
      */
-    public function getIbanIssuers(int $cartId): array
+    public function getIbanIssuers(int $cartId)
     {
+        if (!$this->configService->isIdealIssuerSelectionEnabled()) {
+            return false;
+        }
+
         if (!$this->configService->isAvailablePaymentMethodsCheckEnabled()) {
             $issuers = [];
 

etc/adminhtml/system.xml

@@ -297,6 +297,16 @@
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                     <config_path>payment/cm_payments_ideal/active</config_path>
                 </field>
+                <field id="enable_issuer_selection" translate="label comment" type="select" sortOrder="35" showInDefault="1" showInWebsite="1"
+                       showInStore="1" canRestore="1">
+                    <label>Enable Issuer Select</label>
+                    <comment><![CDATA[Enable Ideal Issuer Checkout Selection (Deprecated)]]></comment>
+                    <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
+                    <config_path>payment/cm_payments_ideal/enable_issuer_selection</config_path>
+                    <depends>
+                        <field id="active">1</field>
+                    </depends>
+                </field>
                 <field id="title" translate="label" type="text" sortOrder="20" showInDefault="1" showInWebsite="1"
                        showInStore="1" canRestore="1">
                     <label>Title</label>

etc/config.xml

@@ -52,6 +52,7 @@
             </cm_payments>
             <cm_payments_ideal>
                 <active>0</active>
+                <enable_issuer_selection>1</enable_issuer_selection>
                 <mode>direct</mode>
                 <model>CMPaymentsIdealFacade</model>
                 <order_status>pending</order_status>

view/frontend/web/js/view/payment/method-renderer/ideal.js

@@ -42,8 +42,13 @@ define([
 
             var self = this;
 
-            getIssuers().done(function(issuers) {
-                self.issuers(issuers);
+            getIssuers().done(function (issuers) {
+                if ((issuers !== undefined) && (issuers.length > 0)) {
+                    $('#iban-select').show();
+                    $('#iban-select > form > select').attr('data-validate', "{required:true}");
+                    self.issuers(issuers);
+                }
+
                 $('#iban-select').trigger('processStop');
             });