Skip to content

Conversation

dylanhmorris
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

Qualifies the namespace for epidatasets::state_census in two internal functions. The alternative would be to import that name, but qualifying the namespace seems better given that it is only used twice in the codebase.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

Copy link
Contributor

@dajmcdon dajmcdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylanhmorris Thanks for catching this. It must have been sitting here for a while. Do you need this change on main as well?

@dylanhmorris
Copy link
Contributor Author

Thanks for the quick review! Would be great to have the patch in main ASAP, but we can point at dev for a bit if necessary.

@dajmcdon dajmcdon merged commit 5f5c470 into cmu-delphi:dev Sep 19, 2025
1 check passed
dajmcdon added a commit that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

epipredict::flusight_hub_formatter() errors without a library(epipredict) call
2 participants