Skip to content

Commit 1b3888f

Browse files
authored
GitHub Action Updates - Link Checker on PR (#2968)
* Add a GitHub Action link checker Signed-off-by: Taylor Dolezal <[email protected]> * Update lycheeignore Signed-off-by: Taylor Dolezal <[email protected]> * Update broken links in Best Practices Badge section Signed-off-by: Taylor Dolezal <[email protected]> * Remove non-functional david-dm.org badge Signed-off-by: Taylor Dolezal <[email protected]> * Add a GitHub Action link checker that runs during PRs Signed-off-by: Taylor Dolezal <[email protected]> * Update broken microservices link Signed-off-by: Taylor Dolezal <[email protected]> --------- Signed-off-by: Taylor Dolezal <[email protected]>
1 parent 5c8318b commit 1b3888f

File tree

4 files changed

+25
-3
lines changed

4 files changed

+25
-3
lines changed

.github/workflows/linkchecker.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: "Code Quality: Link Checker"
2+
3+
on:
4+
pull_request:
5+
branches:
6+
- master
7+
8+
jobs:
9+
linkchecker:
10+
runs-on: ubuntu-latest
11+
steps:
12+
- uses: actions/checkout@v3
13+
14+
- name: Link Checker
15+
uses: lycheeverse/[email protected]
16+
with:
17+
fail: true
18+
env:
19+
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}

.lycheeignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
linkedin.com
2+
localhost*
3+
crunchbase.com

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
[![Gitpod ready-to-code](https://img.shields.io/badge/Gitpod-ready--to--code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/cncf/landscape/blob/master/landscape.yml) [![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/1767/badge)](https://bestpractices.coreinfrastructure.org/projects/1767) [![Dependency Status](https://img.shields.io/david/cncf/landscape.svg?style=flat-square)](https://david-dm.org/cncf/landscape) [![Netlify Status](https://api.netlify.com/api/v1/badges/91337728-8166-4c8f-bc39-9159bf97dcbc/deploy-status)](https://app.netlify.com/sites/landscape/deploys)
1+
[![Gitpod ready-to-code](https://img.shields.io/badge/Gitpod-ready--to--code-blue?logo=gitpod)](https://gitpod.io/#https://github.com/cncf/landscape/blob/master/landscape.yml) [![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/1767/badge)](https://bestpractices.coreinfrastructure.org/projects/1767) [![Netlify Status](https://api.netlify.com/api/v1/badges/91337728-8166-4c8f-bc39-9159bf97dcbc/deploy-status)](https://app.netlify.com/sites/landscape/deploys)
22

33
# Cloud Native Landscape
44

@@ -88,7 +88,7 @@ The update server enhances the source data with the fetched data and saves the r
8888
As explained at https://bestpractices.coreinfrastructure.org/:
8989
>The Linux Foundation (LF) Core Infrastructure Initiative (CII) Best Practices badge is a way for Free/Libre and Open Source Software (FLOSS) projects to show that they follow best practices. Projects can voluntarily self-certify, at no cost, by using this web application to explain how they follow each best practice. The CII Best Practices Badge is inspired by the many badges available to projects on GitHub. Consumers of the badge can quickly assess which FLOSS projects are following best practices and as a result are more likely to produce higher-quality secure software.
9090
91-
The interactive landscape displays the status (or non-existence) of a badge for each open-source project. There's also a feature not available through the filter bar to see all items [with](https://landscape.cncf.io/bestpractices=yes) and [without](https://landscape.cncf.io/bestpractices=no) badges. Note that a passing badge is a requirement for projects to [graduate](https://github.com/cncf/toc/blob/master/process/graduation_criteria.adoc) in the CNCF.
91+
The interactive landscape displays the status (or non-existence) of a badge for each open-source project. There's also a feature not available through the filter bar to see all items [with](https://landscape.cncf.io/card-mode/?bestpractices=yes) and [without](https://landscape.cncf.io/card-mode/?bestpractices=no) badges. Note that a passing badge is a requirement for projects to [graduate](https://github.com/cncf/toc/blob/main/process/graduation_criteria.md) in the CNCF.
9292

9393
For projects using a GitHub organisation, and the url used for the badge is the organisation not the repository, `url_for_bestpractices` needs to be specified in the projects section in the [landscape.yml](landscape.yml).
9494

guide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -475,7 +475,7 @@ them.
475475

476476
As mentioned in the section ‘cloud native networking’, in cloud native architectures, applications
477477
are broken down into small components, or services, each placed in a container. You may have heard
478-
of them referred to as [microservices](https://github.com/cncf/glossary/blob/main/content/en/microservices.md).
478+
of them referred to as [microservices](https://github.com/cncf/glossary/blob/main/content/en/microservices-architecture.md).
479479
Instead of having one big app (often known as a ‘monolith’) you now have dozens or even hundreds
480480
of (micro)services. And each of these services needs resources, monitoring, and fixing if a problem
481481
occurs. While it may be feasible to do all those things manually for a single service, you'll need

0 commit comments

Comments
 (0)