Updates to testsuite according to cnf-testsuite/helm#6 #2218
+61
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
Signed-off-by: Rafal Lal <[email protected]>
rafal-lal
force-pushed
the
rlal_helm_shard_refactor_updates
branch
3 times, most recently
from
e002060 to
0339ddd
Compare
Signed-off-by: Rafal Lal <[email protected]>
rafal-lal
force-pushed
the
rlal_helm_shard_refactor_updates
branch
from
0339ddd to
dbf5630
Compare
Signed-off-by: Rafal Lal <[email protected]>
rafal-lal
force-pushed
the
rlal_helm_shard_refactor_updates
branch
from
4f3e897 to
baac78a
Compare
rafal-lal
commented
Feb 24, 2025
| @@ -4,6 +4,6 @@ deployments: | |||
| helm_charts: | |||
| - name: jenkins | |||
| helm_chart_name: jenkins | |||
| helm_values: --set controller.sidecars.configAutoReload.enabled=false | |||
| helm_values: --set controller.sidecars.configAutoReload.enabled=false --set controller.installPlugins=false | |||
There was a problem hiding this comment.
Jenkins consistently failed to install (error in init container during plugins installation).
svteb
reviewed
Feb 25, 2025
| @@ -23,7 +23,7 @@ module CNFInstall | |||
| begin | |||
| CNFManager.ensure_namespace_exists!(helm_namespace) | |||
| #TODO (kosstennbl) fix Helm install to add -n to namespace and remove it there | |||
| response = Helm.install(release_name: @deployment_name, helm_chart: chart_path, namespace: "-n #{helm_namespace}", values: helm_values) | |||
| response = Helm.install(@deployment_name, chart_path, namespace: "#{helm_namespace}", values: helm_values) | |||
There was a problem hiding this comment.
Unnecessary "#{helm_namespace}", just pass the variable
There was a problem hiding this comment.
Will fix once approved to go in, dont want to restart long CI.
There was a problem hiding this comment.
I don't think that it can be approved before review comments are addressed.
There was a problem hiding this comment.
Well, what I meant is when all the involved people will leave theirs comments.
| @@ -21,7 +21,7 @@ module FluentManager | |||
| Helm.helm_repo_add(flavor_name, repo_url) | |||
| File.write(values_file, values_macro) | |||
| begin | |||
| Helm.install("--values #{values_file} -n #{TESTSUITE_NAMESPACE} #{flavor_name} #{chart}") | |||
| Helm.install("#{flavor_name}", "#{chart}", namespace: TESTSUITE_NAMESPACE, values: "--values #{values_file}") | |||
There was a problem hiding this comment.
Will fix once approved to go in, dont want to restart long CI.
martin-mat
requested changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to testsuite according to helm shard refactor (changes can be found here cnf-testsuite/helm#6). No other changes added besides removing duplicate from
shards.yamlfile.Issues:
Refs: #2199
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue