Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shard migration: Migrate cnf-testsuite org shards to main testsuite #2226

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

svteb
Copy link
Collaborator

@svteb svteb commented Feb 27, 2025

Description

  • After further discussion we have decided to migrate the shards in smaller batches that make sense (i.e. one shard = one commit).
  • An overarching final commit will resolve all the dependency errors (require statements) and delete cnf-testsuite org shards from shard.yaml.
  • Some apparent bug fixes will also be done in a shard's migration commit.

We have come to the conclusion that the shards should be moved to src/modules/<shard_name>/..., please comment if you know of a better placement.

The pull request is currently being blocked by #2221 and a future(?) cluster_tools pull request change, once these are done, we can proceed with moving them to main testsuite project.

Any major code refactors are subject to future pull requests, this is only migration.

Change log:

  • Migrated tar (found out that due to duplicity conflicts between /lib and src/modules, the code breaks, thus we cannot merge until all shards are resolved). View this actions run for further info.
  • Find module from find shard absorbed into tar (specifically tar_spec.cr, since the find shard only had a single function and it was only used in the spec tests of tar).

Issues:

Refs: #2219

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

Refs: #2213
- Migrates tar shard to main testsuite project.
- Additionally migrates/removes the find shard, the Find module only
  has one method and it is only used in tar spec tests. I've thus
  decided to move it into tar_spec.cr, this change can be reversed in
  the future if necessary.
- Tar spec tests are intentionally not runnable, as there is currently
  a conflict between the lib and src/modules (duplicate declarations).

Signed-off-by: svteb <[email protected]>
@svteb svteb marked this pull request as draft February 27, 2025 11:28
@svteb svteb changed the title Shard migration [1]: Migrate tar (and find) shard Shard migration: Migrate cnf-testsuite org shards to main testsuite Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant