-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyUnrunDoctestsBear: Detect doctests that are not actually run #1283
Comments
this should be using the AnnotationBear but not until it has been refactored by @abhsag24 |
@NiklasMM suggested PyIgnoredDoctestsBear, which I think is better :) |
@sils How exactly are you suggesting to solve this with AnnotationBear ? |
@aptrishu annotationbear identifies comments right? |
yup. It does. |
@sils Still blocked? |
review please :P #1332 |
Clicked on the link, it took a good 2-3 seconds to load. Immediately realized it's that PR :D silently goes back to something else without reviewing |
Another gotcha with doctest is that they are ignored in nested functions and maybe other similar obscure locations. See pyflakes tests for details. |
This will actually not fail tests because a linebreak is required between the english sentence and the doctest.
A nice security feature :)
The text was updated successfully, but these errors were encountered: